Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16589 test: Support Functional Hardware Medium VMD stage (#15166) #15295

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

phender
Copy link
Contributor

@phender phender commented Oct 10, 2024

Add Build with parameters option to run the stage. Enable some basic
harness tests to run in the stage.

Enable a stage for functional tests that require VMD hardware.

Skip-func-hw-test-medium: true
Skip-func-hw-test-medium-vmd: false
Skip-func-hw-test-large: true
Test-tag: test_always_passes_hw test_load_mpi_hw

Required-githooks: true

Signed-off-by: Phil Henderson phillip.henderson@intel.com

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Add Build with parameters option to run the stage.  Enable some basic
harness tests to run in the stage.

Skip-func-hw-test-medium: true
Skip-func-hw-test-medium-vmd: false
Skip-func-hw-test-large: true
Test-tag: test_always_passes_hw test_load_mpi_hw

Signed-off-by: Phil Henderson <phillip.henderson@intel.com>
Enable a stage for functional tests that require VMD hardware.

Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test-medium-vmd: false
Test-tag: VmdLedStatus NvmeFaultReintegrate

Signed-off-by: Phil Henderson <phillip.henderson@intel.com>
Copy link

Ticket title is 'Prevent false failures when VMD tests run on non-VMD hardware'
Status is 'Awaiting backport'
Labels: 'request_for_2.6.2,testp2,scrubbed_2.8'
https://daosio.atlassian.net/browse/DAOS-16589

@phender
Copy link
Contributor Author

phender commented Oct 11, 2024

@phender phender marked this pull request as ready for review October 11, 2024 15:11
@phender phender requested review from a team as code owners October 11, 2024 15:11
@phender phender added clean-cherry-pick Cherry-pick from another branch that did not require additional edits forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. labels Oct 11, 2024
@daltonbohning daltonbohning requested a review from a team October 11, 2024 17:57
@daltonbohning daltonbohning merged commit a1c6beb into release/2.6 Oct 11, 2024
44 checks passed
@daltonbohning daltonbohning deleted the pahender/DAOS-16589 branch October 11, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean-cherry-pick Cherry-pick from another branch that did not require additional edits forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Development

Successfully merging this pull request may close these issues.

2 participants