Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16702 rebuild: restart rebuild for a massive failure case #15343

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

DAOS-16702 rebuild: restart rebuild for a massive failure case #15343

wants to merge 3 commits into from
+83 −1

Conversation

liuxuezhao
Copy link
Contributor

In special massive failure case -

  1. some engines down and triggered rebuild.
  2. one engine participated the rebuild, not finished yet, it down again, the #failures exceeds pool RF and will not change pool map.
  3. That engine restarted by administrator.

In that case should recover the rebuild task on the engine, to simplify it now just abort and retry the global rebuild task.
No such issue by the typical recover approach that restart the whole system including the PS leader.

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 18, 2024 •
edited
Loading

Ticket title is 'Rebuilding cannot be completed after restarting ranks in cases of massive failures.'
Status is 'In Progress'
https://daosio.atlassian.net/browse/DAOS-16702

@liuxuezhao liuxuezhao marked this pull request as ready for review October 18, 2024 10:55
@liuxuezhao liuxuezhao requested review from a team as code owners October 18, 2024 10:55
@liuxuezhao liuxuezhao removed request for a team October 18, 2024 10:55
@liuxuezhao
DAOS-16702 rebuild: restart rebuild for a massive failure case
967b84e 
In special massive failure case -
1. some engines down and triggered rebuild.
2. one engine participated the rebuild, not finished yet, it down again,
   the #failures exceeds pool RF and will not change pool map.
3. That engine restarted by administrator.

In that case should recover the rebuild task on the engine, to simplify it now just
abort and retry the global rebuild task.
No such issue by the typical recover approach that restart the whole
system including the PS leader.
Skip-nlt: true

Signed-off-by: Xuezhao Liu <xuezhao.liu@intel.com>
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15343/2/execution/node/1397/log

@liuxuezhao liuxuezhao requested a review from liw October 21, 2024 01:03
liw
liw requested changes Oct 21, 2024
View reviewed changes
src/pool/srv_pool.c Outdated Show resolved Hide resolved
src/pool/srv_pool.c Outdated Show resolved Hide resolved
@liuxuezhao liuxuezhao requested a review from liw October 21, 2024 01:57
liw
liw reviewed Oct 21, 2024
View reviewed changes
src/pool/srv_pool.c Outdated Show resolved Hide resolved
src/pool/srv_pool.c Outdated Show resolved Hide resolved
@liuxuezhao
DAOS-16702 rebuild: address comment
a952a14 
Skip-nlt: true
Signed-off-by: Xuezhao Liu <xuezhao.liu@intel.com>
@liuxuezhao liuxuezhao requested a review from liw October 21, 2024 02:07
liw
liw previously approved these changes Oct 21, 2024
View reviewed changes
wangshilong
wangshilong reviewed Oct 21, 2024
View reviewed changes
src/pool/srv_pool.c
@@ -1489,6 +1526,9 @@ handle_event(struct pool_svc *svc, struct pool_svc_event_set *event_set)

if (event->psv_src != CRT_EVS_SWIM || event->psv_type != CRT_EVT_ALIVE)
continue;

pool_restart_rebuild_if_rank_wip(svc->ps_pool, event->psv_rank);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Question] As @liw mentioned last week, if this ALIVE event means rank state from SUSPECT to ALIVE , and there is a rebuild running, and its rebuild status is not finished, we will abort rebuild unexpected ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what method can differenciate/avoid that case, even one engine crashed and reboot again in short time, it possibly reflect as SUSPECT+ALIVE.
Seems in SWIM protocol, it is not required to report ALIVE event when remove from SUSPECT status.

wangshilong
wangshilong reviewed Oct 21, 2024
View reviewed changes
Copy link
Contributor

@wangshilong wangshilong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I run test locally, somehow rebuild finished but with 2007 errors, and retry forever.

@liuxuezhao
Copy link
Contributor Author

I run test locally, somehow rebuild finished but with 2007 errors, and retry forever.

at my side I tested DER_STALE will retry and finish. I'll check details with you offline

@wangshilong
Copy link
Contributor

I run test locally, somehow rebuild finished but with 2007 errors, and retry forever.

at my side I tested DER_STALE will retry and finish. I'll check details with you offline

See logs here:

https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-15354/1/artifact/Functional%20on%20EL%208.8/control/dmg_pool_query_ranks.py/job.log/*view*/

dmg pool query timeout after restarting rank, but rebuild did not finish too.

@liuxuezhao
DAOS-16702 rebuild: CRT_EVT_ALIVE possibly from CRT_EVS_GRPMOD
0a34490 
refine handle_event.
Skip-nlt: true

Signed-off-by: Xuezhao Liu <xuezhao.liu@intel.com>
@liuxuezhao
Copy link
Contributor Author

https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-15354/1/artifact/Functional%20on%20EL%208.8/control/dmg_pool_query_ranks.py/job.log/*view*/

dmg pool query timeout after restarting rank, but rebuild did not finish too.

I ran several test on wolf wit similar steps and be able to reproduce a rebuild timeout issue.
The problem is the ALIVE event got from CRT_EVS_GRPMOD rather than CRT_EVS_SWIM, so cannot ignore CRT_EVS_GRPMOD event.
I changed handle_event a little bit @liw please check if it is good for you.
@wangshilong please retest with the new version. thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangshilong wangshilong wangshilong left review comments

@liw liw liw left review comments

@wangdi1 wangdi1 Awaiting requested review from wangdi1

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liuxuezhao @daosbuild1 @wangshilong @liw