Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check getCurrentBlock return value validity #1648

Closed
orenyodfat opened this issue Apr 30, 2020 · 3 comments · Fixed by #1649
Closed

check getCurrentBlock return value validity #1648

orenyodfat opened this issue Apr 30, 2020 · 3 comments · Fixed by #1649
Assignees

Comments

@orenyodfat
Copy link
Contributor

getCurrentBlock might return null in some cases.
while using it there is a need to check for its return value.

especially here
if the return value is null , a special care must be taken .
(This is the current case with Biconomy pr) .

@tibetsprague
Copy link
Contributor

when you say a special care, do you mean we should still show the notification or not? it looks to me like there is a real error preventing access to the subgraph with Biconomy, in that case I think we want to know that and report that to the user

@dkent600
Copy link
Contributor

An inability to use getBlock does not mean we can't access the subgraph.

@tibetsprague
Copy link
Contributor

should we just remove the block check then in the subgraph warning code? or only use it if we get a block number

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants