handle errors in getLatestBlock #1649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tibetsprague
approved these changes
Apr 30, 2020
When we return null the entire iteration is aborted. We do nothing. (This is commented in the code) |
orenyodfat
reviewed
Apr 30, 2020
| @@ -126,7 +134,7 @@ export async function initializeArc(provider?: any): Promise<boolean> { | |||
| const retryLink = new RetryLink({ | |||
| attempts: { | |||
| max: 5, | |||
| retryIf: (error, _operation) => { | |||
| retryIf: (error, _operation) => { | |||
There was a problem hiding this comment.
why this change ? how the linter did not catch that before..is it catching that at all?
if linter does not care about so leave these update for other "lint": pr.. it is difficult to review with all these changes.
There was a problem hiding this comment.
- On this github page you can tell the github to ignore whitespage differences
- I already created a separate PR to make the linter catch these: lint: eliminate redundant multiple spaces #1650
orenyodfat
reviewed
Apr 30, 2020
| const curBlock = (await getCurrentBlock()).number; | ||
| const curBlock = (await getCurrentBlock())?.number; | ||
| if (curBlock === undefined) { | ||
| return; // try again next time |
There was a problem hiding this comment.
maybe log something to the console..here?
There was a problem hiding this comment.
done (in getCurrentBlock)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #1648
Mainly to the error: "connection not open on send()" in
web3.eth.getBlock("latest")See: web3/web3.js#1354