Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-0.10.2 #1517

Merged
merged 11 commits into from
Mar 21, 2020
Merged

release-0.10.2 #1517

merged 11 commits into from
Mar 21, 2020

Conversation

dkent600
Copy link
Contributor

No description provided.

dependabot bot and others added 5 commits March 13, 2020 21:37
@dependabot
Bump acorn from 5.7.3 to 5.7.4
9671a94 
Bumps [acorn](https://github.com/acornjs/acorn) from 5.7.3 to 5.7.4.
- [Release notes](https://github.com/acornjs/acorn/releases)
- [Commits](acornjs/acorn@5.7.3...5.7.4)

Signed-off-by: dependabot[bot] <support@github.com>
@dkent600
new spinny busy icon (#1496)
1d036d3 
* start

* less code

* new icon, changelog

* new icon

* put spinny icon always in the middle of the page

* tweak
@tibetsprague
Merge pull request #1511 from daostack/dependabot/npm_and_yarn/acorn-…
02e6cf8 
…5.7.4

Bump acorn from 5.7.3 to 5.7.4
@orenyodfat @dkent600
fix CreateKnowGenericSchemeProposal - uint256 field should be rendere…
bd75ae3 
…d as "string" (not as "number") (#1516)

* uint256- to string

* toString

* remove console.log

* use ""+userValue

* use BN

* fix

* .

* get uint256 as string

* do not use type=number for uint256

* lint

* validity check

* update changelog

* update package version

Co-authored-by: Doug Kent <github@douglaskent.com>
@dkent600
improve package vulnerabilities (#1500)
00d07ba 
* start

* fix prod build error

* remove prod build fix

* package-lock
@orenyodfat orenyodfat temporarily deployed to alchemy-staging-rinkeby March 16, 2020 19:40 Inactive
@orenyodfat orenyodfat had a problem deploying to alchemy-staging-xdai March 16, 2020 19:40 Failure
@leviadam leviadam temporarily deployed to test-the-graph March 16, 2020 19:40 Inactive
@orenyodfat orenyodfat temporarily deployed to alchemy-staging-mainnet March 16, 2020 19:40 Inactive
@orenyodfat orenyodfat had a problem deploying to alchemy-staging-xdai March 16, 2020 20:34 Failure
@orenyodfat orenyodfat temporarily deployed to alchemy-staging-xdai March 16, 2020 20:54 Inactive
@orenyodfat orenyodfat temporarily deployed to alchemy-staging-rinkeby March 16, 2020 21:01 Inactive
orenyodfat
orenyodfat suggested changes Mar 16, 2020
View reviewed changes
Copy link
Contributor

@orenyodfat orenyodfat left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this increase Heroku slug size with around 180mega.
how come ?

@orenyodfat orenyodfat temporarily deployed to alchemy-dev-alp269kagpiqvdd52h March 16, 2020 21:16 Inactive
@EzraWeller
Copy link
Contributor

EzraWeller commented Mar 16, 2020 •
edited
Loading

@tibetsprague
On rinkeby, when I click on the address of an unsupported scheme, I am getting this error:
Annotation 2020-03-16 182537
Annotation 2020-03-16 182536
Is this an issue with #1501 or am I misinterpreting what that was meant to change?
Resolves: #1518

@EzraWeller
Copy link
Contributor

EzraWeller commented Mar 16, 2020 •
edited
Loading

Getting an error on the redemption page on rinkeby:
Redeem page error
(clicked on "view all" from the redemption drop down)
Resolves: #1519

@dkent600
Copy link
Contributor Author

dkent600 commented Mar 16, 2020 •
edited
Loading

@EzraWeller Were you going to create tickets for bugs you find? (Be sure to give us good repro steps :-) )

And you can go to "File Changes" tab, click "Review changes" and request changes, officially rejecting this PR and preventing it from being merged until you've got satisfaction.

@EzraWeller
Copy link
Contributor

EzraWeller commented Mar 16, 2020 •
edited
Loading

I wasn't sure if it would be worth in these cases -- it would be important for me to reference any new issues I create in this comment section, right? To keep track of the issues related to this release? Or should I track them another way?

Edit: Made new issues for the two errors above. Hopefully the repro steps are clear enough. Let me know if not.

This was referenced Mar 16, 2020
Closed
Closed
@dkent600
Copy link
Contributor Author

dkent600 commented Mar 16, 2020 •
edited
Loading

I wasn't sure if it would be worth in these cases -- it would be important for me to reference any new issues I create in this comment section, right? To keep track of the issues related to this release? Or should I track them another way?

@EzraWeller I'm not sure, but I'm leaning toward referencing each ticket in the description of this PR. Then is appropriate, we could prepend each ticket reference with "Resolves: " so github will automatically close the ticket when this PR is merged.

@orenyodfat orenyodfat temporarily deployed to alchemy-dev-alp269kagpiqvdd52h March 18, 2020 20:24 Inactive
@orenyodfat orenyodfat temporarily deployed to alchemy-dev-alp269kagpiqvdd52h March 18, 2020 20:59 Inactive
@orenyodfat orenyodfat temporarily deployed to alchemy-staging-rinkeby March 18, 2020 20:59 Inactive
@orenyodfat orenyodfat temporarily deployed to alchemy-staging-xdai March 18, 2020 20:59 Inactive
@orenyodfat orenyodfat temporarily deployed to test-the-graph March 18, 2020 20:59 Inactive
@orenyodfat orenyodfat temporarily deployed to alchemy-staging-mainnet March 18, 2020 20:59 Inactive
@tibetsprague tibetsprague temporarily deployed to alchemy-staging-mainnet March 18, 2020 21:37 Inactive
@leviadam leviadam temporarily deployed to test-the-graph March 18, 2020 21:37 Inactive
@tibetsprague tibetsprague temporarily deployed to alchemy-staging-xdai March 18, 2020 21:37 Inactive
@EzraWeller
Copy link
Contributor

Okay, I'm ready approve this. #1519 is still open, but it doesn't seem to be an issue on mainnet (b/c they aren't as many pending redemptions?).

@tibetsprague
Copy link
Contributor

@EzraWeller yeah I’m thinking about that one but not an issue on prod yet

@dkent600 dkent600 requested a review from EzraWeller March 19, 2020 12:04
@dkent600 dkent600 temporarily deployed to alchemy-staging-rinkeby March 19, 2020 14:47 Inactive
@dkent600 dkent600 temporarily deployed to alchemy-staging-mainnet March 19, 2020 14:48 Inactive
EzraWeller
EzraWeller previously approved these changes Mar 19, 2020
View reviewed changes
@orenyodfat orenyodfat temporarily deployed to alchemy-staging-mainnet March 19, 2020 17:14 Inactive
@orenyodfat orenyodfat temporarily deployed to alchemy-staging-rinkeby March 19, 2020 17:14 Inactive
@orenyodfat orenyodfat temporarily deployed to alchemy-staging-xdai March 19, 2020 17:14 Inactive
@dkent600 dkent600 temporarily deployed to alchemy-dev-alp269kagpiqvdd52h March 19, 2020 17:20 Inactive
orenyodfat
orenyodfat reviewed Mar 19, 2020
View reviewed changes
CHANGELOG.md
- Fix bug when entering numbers for uint256 data types in the GenericScheme new proposal modal

- Bugs Fixed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about the animation pr ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1526

@dkent600
Copy link
Contributor Author

this increase Heroku slug size with around 180mega.
how come ?

@orenyodfat See: #1528

@dkent600
downgrade 3Box (#1528)
65a64ce 
* downgrade 3Box

* install multicodec so 3box will build

* update package-lock.json

* restore build script

* downgrade webpack-bundle-analyzer

* revert downgrade webpack-bundle-analyzer

* lock 3box into 1.16.1

* revert webpack-bundle-analyzer

* revert again (?!)

* update package-lock.json
@orenyodfat orenyodfat temporarily deployed to alchemy-staging-xdai March 21, 2020 00:21 Inactive
@leviadam leviadam temporarily deployed to test-the-graph March 21, 2020 00:21 Inactive
@dkent600 dkent600 temporarily deployed to alchemy-dev-alp269kagpiqvdd52h March 21, 2020 00:21 Inactive
@dkent600 dkent600 temporarily deployed to alchemy-staging-mainnet March 21, 2020 00:21 Inactive
@dkent600 dkent600 temporarily deployed to alchemy-staging-rinkeby March 21, 2020 00:21 Inactive
@dkent600
changelog (#1526)
189541f 
* new busy waiting animation

* edit
@dkent600 dkent600 temporarily deployed to alchemy-staging-rinkeby March 21, 2020 00:25 Inactive
@leviadam leviadam temporarily deployed to test-the-graph March 21, 2020 00:25 Inactive
@dkent600 dkent600 temporarily deployed to alchemy-staging-mainnet March 21, 2020 00:25 Inactive
@orenyodfat orenyodfat temporarily deployed to alchemy-staging-xdai March 21, 2020 00:25 Inactive
@dkent600 dkent600 temporarily deployed to alchemy-dev-alp269kagpiqvdd52h March 21, 2020 00:25 Inactive
@dkent600 dkent600 merged commit 8a1e228 into master Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orenyodfat orenyodfat orenyodfat approved these changes

@EzraWeller EzraWeller EzraWeller left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dkent600 @EzraWeller @tibetsprague @orenyodfat @leviadam