Fix dxd token display #2068
Merged
Fix dxd token display #2068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orenyodfat
reviewed
Aug 14, 2020
| @@ -48,7 +48,7 @@ | |||
| "name": "Tether USD", | |||
| "symbol": "USDT" | |||
| }, | |||
| "0xCc80C051057B774cD75067Dc48f8987C4Eb97A5e": { | |||
| "0xcc80c051057b774cd75067dc48f8987c4eb97a5e": { | |||
There was a problem hiding this comment.
why not alway do toLowerCase when reading that ?
There was a problem hiding this comment.
believe me I tried to do something like that, but those are property names, not values. So requires that whole data structure change.
orenyodfat
approved these changes
Aug 14, 2020
dkent600
added a commit
that referenced
this pull request
Aug 17, 2020
* cast all token addresses to lowercase * bump version, changelog
dkent600
added a commit
that referenced
this pull request
Aug 17, 2020
dkent600
added a commit
that referenced
this pull request
Aug 17, 2020
* cast all token addresses to lowercase * bump version, changelog
dkent600
added a commit
that referenced
this pull request
Aug 17, 2020
dkent600
added a commit
that referenced
this pull request
Aug 17, 2020
* cast all token addresses to lowercase * bump version, changelog
dkent600
added a commit
that referenced
this pull request
Sep 22, 2020
* cast all token addresses to lowercase * bump version, changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #2065
Same fix applies to NEC
I'm not wild about this because it doesn't address the fact that someone has to remember/document that these tokens must always be submitted in lowercase.