Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give GenericSchemes a name, default proposal params #621

Open
dkent600 opened this issue Apr 5, 2019 · 4 comments
Open

Give GenericSchemes a name, default proposal params #621

dkent600 opened this issue Apr 5, 2019 · 4 comments

Comments

@dkent600
Copy link
Contributor

dkent600 commented Apr 5, 2019

Feature request: Let GenericScheme instances be configured with a name, default ABI and contract address. dApps such as Alchemy could display the name to automatically identify each GenericScheme, and supply nulls for the ABI and contract address when creating a proposal, to cause execute to use the defaults.

These configurations would be part of the scheme parameters, settable by SchemeRegistrar.

dApps would obtain the default ABI from the GenericScheme params and parse it to identify any contract.function params that do not have values. For those params that do not have values, the dApp would generate a form enabling the user to enter the values. The dApp would poke these values into the ABI and submit that completed ABI to proposeCall (when proposals are created).

These features would enable dApps like Alchemy to use GenesisScheme instances without requiring any custom code to support the GenericScheme.

@dkent600 dkent600 changed the title Give GenericSchemes a name Give GenericSchemes a name and ABI Apr 6, 2019
@dkent600 dkent600 changed the title Give GenericSchemes a name and ABI Give GenericSchemes a name and default ABI Apr 6, 2019
@dkent600 dkent600 changed the title Give GenericSchemes a name and default ABI Give GenericSchemes a name and default proposal params Apr 6, 2019
@orenyodfat
Copy link
Contributor

GenericScheme with default address and ABI might be a nice idea though it might be limited to cases with ABI without params (void) or ABI with pre known params values.
Any how , I guess one can always inherit GenericScheme , give it a name ,default values and add its own custom propose functions.

@dkent600
Copy link
Contributor Author

dkent600 commented Apr 6, 2019

[Note: this response to Oren's comments above is obsoleted by the addition of the request for replaceable param values in the ABI]

The advantage of default params (over subclassing GenericScheme) is that people won't have to write any code. Rather, they would be able to register a GenericScheme with the desired params using SchemeRegistrar. No coding required.

GenericScheme with default address and ABI might be a nice idea though it might be limited to cases with ABI without params (void) or ABI with pre known params values

Indeed, but combine this feature request with this one, and you have a lot of flexibiity.

@dkent600 dkent600 changed the title Give GenericSchemes a name and default proposal params Give GenericSchemes a name, default proposal params, replaceable ABI param values. Apr 7, 2019
@dkent600 dkent600 changed the title Give GenericSchemes a name, default proposal params, replaceable ABI param values. Give GenericSchemes a name, default proposal params Apr 7, 2019
@dkent600
Copy link
Contributor Author

dkent600 commented Apr 8, 2019

If a DAO wants to have multiple sets of default values, then it would need to deploy an additional GenericScheme instance for each default set. That seems less than ideal.

@dkent600
Copy link
Contributor Author

To address my comment just above, see this PR: #623

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants