Add Transition Scheme #769
Conversation
| */ | ||
| function transferAssets() external { | ||
| for (uint256 i=0; i < assetAddresses.length; i++) { | ||
| Controller(avatar.owner()).genericCall( |
There was a problem hiding this comment.
What is the point of that, we have nothing to do with the returned value here...
There was a problem hiding this comment.
check if the transfer success or not .
There was a problem hiding this comment.
... which one could test in advance using .call
|
What is the function of this scheme? |
|
To help DAOs migrate from the old stack to the new one. |
| * @param _newAvatar the avatar to migrate to | ||
| * @param _externalTokens external tokens to allow transfer to the new avatar | ||
| * @param _assetAddresses the assets to transfer | ||
| * @param _selectors the functions to call to to transfer the assets |
There was a problem hiding this comment.
Does this include reputation?
There was a problem hiding this comment.
No, reputation is recreated in the new DAO
There was a problem hiding this comment.
Is there any other plan for transferring rep from a 1.0 DAO to a 2.0 DAO?
| * @param _newAvatar the avatar to migrate to | ||
| * @param _externalTokens external tokens to allow transfer to the new avatar | ||
| * @param _assetAddresses the assets to transfer | ||
| * @param _selectors the functions to call to to transfer the assets |
There was a problem hiding this comment.
Would be good to document here the form a function must take, like what parameters and return value.
There was a problem hiding this comment.
It is a standard selector per the ABI structure.
There was a problem hiding this comment.
A selector is an ABI specification for any arbitrary function. Don't the selectors in this list have to specify functions that have a specific set of parameters and parameter types?
| Avatar _avatar, | ||
| address payable _newAvatar, | ||
| address[] calldata _externalTokens, | ||
| address[] calldata _assetAddresses, |
There was a problem hiding this comment.
how about cap the number of asserts with a number which is applicable ?
There was a problem hiding this comment.
Why? The number of assets is determined in the initialized, so the DAO knows how many and which assets will be transferred before adding the scheme.
There was a problem hiding this comment.
I mean in terms of gas usage ..while iterating over the assets.
There was a problem hiding this comment.
I think we can do enough assets at a time to make it unnecessary, but if you want we can add it. I could add a test to see how many we can do at a time but it'd be just a rough estimation as different assets will probably cost differently.
There was a problem hiding this comment.
test with normal transfer ownership
There was a problem hiding this comment.
ok I added a test transferring 101 assets.
| avatar = _avatar; | ||
| newAvatar = _newAvatar; | ||
| externalTokens = _externalTokens; | ||
| assetAddresses = _assetAddresses; |
There was a problem hiding this comment.
lets cap this array length with 100
|
|
||
| contract TransitionScheme { | ||
|
|
||
| uint public constant ASSETS_CAP = 100; |
No description provided.