Competition : Add Redemption period #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
orenyodfat
commented
Jul 15, 2020
•
orenyodfat
commented
- this is to avoid the dao depend on all suggester to redeem their rewards to get back the leftover using sendLeftOverFunds
added 2 commits
July 15, 2020 20:35
ben-kaufman
reviewed
Jul 15, 2020
contracts/schemes/Competition.sol
Outdated
| @@ -274,13 +274,9 @@ contract Competition { | |||
| */ | |||
| function sendLeftOverFunds(bytes32 _proposalId) public { | |||
| // solhint-disable-next-line not-rely-on-time | |||
| require(proposals[_proposalId].endTime < now, "competition is still on"); | |||
| require(proposals[_proposalId].endTime.add(REDEMPTION_PERIOD) < now, "redemption period is till on"); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.