Multi Call factory #804
Merged
Multi Call factory #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orenyodfat
suggested changes
Nov 11, 2020
| bytes32 voteParams; | ||
| if (_voteParamsType == FAST) { | ||
| // Fast params hash | ||
| voteParams = bytes32(0x1b46f925b15bc0590168247d8df7f72773ca64dec3334183b5387dd3945f7f2e); |
There was a problem hiding this comment.
I think that we might need to check here first if the params are set in the voting machine..
if not it should set it up.
| Avatar _avatar, | ||
| IntVoteInterface _votingMachine, | ||
| uint8 _voteParamsType, | ||
| bytes32 _voteParamsHash, |
There was a problem hiding this comment.
lets add also the gov params..
something like https://github.com/daostack/arc/blob/master-2/contracts/schemes/ArcScheme.sol#L33
orenyodfat
suggested changes
Nov 11, 2020
orenyodfat
reviewed
Nov 11, 2020
|
|
||
| contract('genericSchemeMultiCallFactory', function(accounts) { | ||
| before(function() { | ||
| helpers.etherForEveryone(accounts); |
There was a problem hiding this comment.
I think this is redundant
orenyodfat
reviewed
Nov 11, 2020
orenyodfat
reviewed
Nov 11, 2020
orenyodfat
approved these changes
Nov 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.