Fix wingetcreate failure #1227
Merged
Fix wingetcreate failure #1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shivam Kumar <shivamkm07@gmail.com>
Signed-off-by: Shivam Kumar <shivamkm07@gmail.com>
Codecov Report
@@ Coverage Diff @@
## release-1.10 #1227 +/- ##
=============================================
Coverage 26.16% 26.16%
=============================================
Files 38 38
Lines 2599 2599
=============================================
Hits 680 680
Misses 1853 1853
Partials 66 66 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Shivam Kumar <shivamkm07@gmail.com>
Signed-off-by: Shivam Kumar <shivamkm07@gmail.com>
yaron2
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shivam Kumar shivamkm07@gmail.com
Description
Wingetcreate older version (1.1.2.0) uses dotnet 5.0, which has been out of support now and so has been removed from runner image(actions/runner-images#6840). The PR makes the workflow use the latest wingetcreate which uses dotnet 6 and so is available in runner.
It also upgrades helm.sh/helm from v3.10.3->v3.11.1, which was failing go vulnerability check.
The run in my fork with the fix: https://github.com/shivamkm07/cli/actions/runs/4175900276
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1225
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: