chore(deps): bump sarama to v1.41.1 #3109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Pulling in `fix(client): force Event Hubs to use V1_0_0_0` by @dnwe in IBM/sarama#2633 This should avoid dapr hitting any issues with Azure Event Hubs users who might not have followed the instructions in dapr/docs#3474 to pin their version number. Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
|
Oh very cool @dnwe - but will this actually work for us? We are setting a default protocol version of V2_0_0_0. Will this change override it regardless when EventHubs is in use? I thought about adding a similar change myself to Dapr, but the fact you added it to I reached out to the EventHubs team last night by the way to see if they will ever increase their supported Kafka protocol versions :) |
|
@berndverst yes this will cause Sarama to override the config for event hubs at connection time if it is outside the supported range, regardless of what is set in dapr |
berndverst
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pulling in
fix(client): force Event Hubs to use V1_0_0_0by @dnwe in IBM/sarama#2633This should avoid dapr hitting any issues with Azure Event Hubs users who might not have followed the instructions in dapr/docs#3474 to pin their version number.
A small number of other changes are included in the release, but nothing I'd deem to be any additional risk over the existing upgrade to v1.41.0:
https://github.com/IBM/sarama/releases/tag/v1.41.1
Issue reference
Fixes #3104
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: