Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes http endpoint being overwritten by gRPC address argument in constructor #621

Merged
merged 4 commits into from
Oct 31, 2023
Merged

Fixes http endpoint being overwritten by gRPC address argument in constructor #621

merged 4 commits into from
Oct 31, 2023

Conversation

elena-kolevska
Copy link
Contributor

@elena-kolevska elena-kolevska commented Oct 18, 2023 •
edited
Loading

Description

Fixes http endpoint being overwritten by gRPC address argument in constructor.

Issue reference

#620

Checklist

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@elena-kolevska
Fixes bug of constructor argument being used as http endpoint
bf7af70 
Signed-off-by: Elena Kolevska <elena@kolevska.com>
@elena-kolevska elena-kolevska changed the base branch from master to release-1.11 October 18, 2023 17:44
@elena-kolevska
Updates tests
4b85bef 
Signed-off-by: Elena Kolevska <elena@kolevska.com>
@elena-kolevska elena-kolevska changed the title Fix http address Fixes http endpoint being overwritten by address argument in constructor Oct 18, 2023
@elena-kolevska elena-kolevska changed the title Fixes http endpoint being overwritten by address argument in constructor Fixes http endpoint being overwritten by gRPC address argument in constructor Oct 18, 2023
@codecov
Copy link

codecov bot commented Oct 18, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release-1.11@ff08864). Click here to learn what that means.

❗ Current head 4b85bef differs from pull request most recent head 743810c. Consider uploading reports for the commit 743810c to get more accurate results

Additional details and impacted files 
@@               Coverage Diff               @@
##             release-1.11     #621   +/-   ##
===============================================
  Coverage                ?   86.41%           
===============================================
  Files                   ?       74           
  Lines                   ?     3592           
  Branches                ?        0           
===============================================
  Hits                    ?     3104           
  Misses                  ?      488           
  Partials                ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elena-kolevska elena-kolevska marked this pull request as ready for review October 18, 2023 17:54
@elena-kolevska elena-kolevska requested review from a team as code owners October 18, 2023 17:54
@elena-kolevska
Updates the docs explaining how http service invocation should be con…
3b7cd7e 
…figured

Signed-off-by: Elena Kolevska <elena@kolevska.com>
@berndverst
Update daprdocs/content/en/python-sdk-docs/python-client.md
743810c 
Signed-off-by: Bernd Verst <github@bernd.dev>
@berndverst berndverst merged commit 4748755 into dapr:release-1.11 Oct 31, 2023
10 checks passed
elena-kolevska added a commit to elena-kolevska/python-sdk that referenced this pull request Feb 7, 2024
@elena-kolevska
Fixes http endpoint being overwritten by gRPC address argument in con…
88706d5 
…structor (dapr#621)

* Fixes bug of constructor argument being used as http endpoint

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Updates tests

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Updates the docs explaining how http service invocation should be configured

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Update daprdocs/content/en/python-sdk-docs/python-client.md

Signed-off-by: Bernd Verst <github@bernd.dev>

---------

Signed-off-by: Elena Kolevska <elena@kolevska.com>
Signed-off-by: Bernd Verst <github@bernd.dev>
Co-authored-by: Bernd Verst <github@bernd.dev>
Signed-off-by: Elena Kolevska <elena@kolevska.com>
# Conflicts:
#	dapr/clients/__init__.py
#	dapr/clients/http/client.py
#	dapr/clients/http/dapr_invocation_http_client.py
#	tests/clients/test_http_service_invocation_client.py
#	tests/clients/test_secure_http_service_invocation_client.py
elena-kolevska added a commit to elena-kolevska/python-sdk that referenced this pull request Feb 7, 2024
@elena-kolevska
Fixes http endpoint being overwritten by gRPC address argument in con…
11e372c 
…structor (dapr#621)

* Fixes bug of constructor argument being used as http endpoint

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Updates tests

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Updates the docs explaining how http service invocation should be configured

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Update daprdocs/content/en/python-sdk-docs/python-client.md

Signed-off-by: Bernd Verst <github@bernd.dev>

---------

Signed-off-by: Elena Kolevska <elena@kolevska.com>
Signed-off-by: Bernd Verst <github@bernd.dev>
Co-authored-by: Bernd Verst <github@bernd.dev>
Signed-off-by: Elena Kolevska <elena@kolevska.com>
# Conflicts:
#	dapr/clients/__init__.py
#	dapr/clients/http/client.py
#	dapr/clients/http/dapr_invocation_http_client.py
#	tests/clients/test_http_service_invocation_client.py
#	tests/clients/test_secure_http_service_invocation_client.py
berndverst pushed a commit that referenced this pull request Feb 9, 2024
@elena-kolevska
Hotfix from 1.11 (#669)
e73b731 
* Fixes http endpoint being overwritten by gRPC address argument in constructor (#621)

* Fixes bug of constructor argument being used as http endpoint

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Updates tests

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Updates the docs explaining how http service invocation should be configured

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Update daprdocs/content/en/python-sdk-docs/python-client.md

Signed-off-by: Bernd Verst <github@bernd.dev>

---------

Signed-off-by: Elena Kolevska <elena@kolevska.com>
Signed-off-by: Bernd Verst <github@bernd.dev>
Co-authored-by: Bernd Verst <github@bernd.dev>
Signed-off-by: Elena Kolevska <elena@kolevska.com>
# Conflicts:
#	dapr/clients/__init__.py
#	dapr/clients/http/client.py
#	dapr/clients/http/dapr_invocation_http_client.py
#	tests/clients/test_http_service_invocation_client.py
#	tests/clients/test_secure_http_service_invocation_client.py

* Runs ruff

Signed-off-by: Elena Kolevska <elena@kolevska.com>

---------

Signed-off-by: Elena Kolevska <elena@kolevska.com>
berndverst pushed a commit that referenced this pull request Feb 13, 2024
@elena-kolevska
Health check (#670)
f4dc8ce 
* Fixes http endpoint being overwritten by gRPC address argument in constructor (#621)

* Fixes bug of constructor argument being used as http endpoint

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Updates tests

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Updates the docs explaining how http service invocation should be configured

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Update daprdocs/content/en/python-sdk-docs/python-client.md

Signed-off-by: Bernd Verst <github@bernd.dev>

---------

Signed-off-by: Elena Kolevska <elena@kolevska.com>
Signed-off-by: Bernd Verst <github@bernd.dev>
Co-authored-by: Bernd Verst <github@bernd.dev>
Signed-off-by: Elena Kolevska <elena@kolevska.com>
# Conflicts:
#	dapr/clients/__init__.py
#	dapr/clients/http/client.py
#	dapr/clients/http/dapr_invocation_http_client.py
#	tests/clients/test_http_service_invocation_client.py
#	tests/clients/test_secure_http_service_invocation_client.py

* health decorator - first commit

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Fixes tests

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Removes unused imports

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Ruff format

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Adds unit test

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Repalces wait() with @healthcheck decorator in examples

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Ruff

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Linter

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* updates heathcheck decorator to use a global var

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Fixes tests

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Linter fixes

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Removes healthcheck from examples

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Ruff

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* wip

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* wip

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* wip

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* wip

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Set health timeout to 60 seconds

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* wip

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Unit tests passing

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Linter

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Refactor and cleanup

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Refactors client tests for speed and readability

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Small fix

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Add tests performance improvement for actor tests too

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Cosmetic touch up

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Documents the `DAPR_HEALTH_TIMEOUT` environment variable

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* make healthcheck a static method

Signed-off-by: Elena Kolevska <elena@kolevska.com>

---------

Signed-off-by: Elena Kolevska <elena@kolevska.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berndverst berndverst berndverst approved these changes

@artursouza artursouza artursouza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elena-kolevska @artursouza @berndverst