Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds error handling for the async client #671

Merged
merged 4 commits into from
Feb 9, 2024

Conversation

elena-kolevska
Copy link
Contributor

Description

Continuation of #659 for the async client.

Issue reference

#648

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests

Signed-off-by: Elena Kolevska <elena@kolevska.com>
@elena-kolevska elena-kolevska requested review from a team as code owners February 7, 2024 23:20
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (fc0e9d1) 86.37% compared to head (cbc54ea) 86.36%.
Report is 3 commits behind head on main.

❗ Current head cbc54ea differs from pull request most recent head 6148bca. Consider uploading reports for the commit 6148bca to get more accurate results

Files Patch % Lines
dapr/aio/clients/grpc/client.py 91.83% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #671      +/-   ##
==========================================
- Coverage   86.37%   86.36%   -0.01%     
==========================================
  Files          79       79              
  Lines        4094     4121      +27     
==========================================
+ Hits         3536     3559      +23     
- Misses        558      562       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

elena-kolevska and others added 3 commits February 8, 2024 00:09
Signed-off-by: Elena Kolevska <elena@kolevska.com>
Signed-off-by: Elena Kolevska <elena@kolevska.com>
@elena-kolevska
Copy link
Contributor Author

@berndverst the python 3.11 run passes now, after having merged main. We should be good to go.

@berndverst berndverst merged commit 23fc4b1 into dapr:main Feb 9, 2024
14 checks passed
@berndverst
Copy link
Member

@elena-kolevska that makes no sense, but I'll take it :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants