Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brings back a docs link that was removed because it wasn’t online yet #683

Merged
merged 4 commits into from
Apr 30, 2024

Conversation

elena-kolevska
Copy link
Contributor

Brings back the link we removed because it wasn’t online yet

Signed-off-by: Elena Kolevska <elena@kolevska.com>
@elena-kolevska elena-kolevska requested review from a team as code owners March 6, 2024 15:47
@elena-kolevska
Copy link
Contributor Author

@berndverst this link wasn't online until today and we changed it so the examples tests wouldn't fail.
The documents just got published, so I'm adding back the link.

@elena-kolevska elena-kolevska changed the title Brings back the link we removed because it wasn’t online yet Brings back the link that was removed because it wasn’t online yet Mar 6, 2024
Signed-off-by: Elena Kolevska <elena@kolevska.com>
@berndverst
Copy link
Member

@elena-kolevska linter ruff autoformatter is failing. Can you update?

@elena-kolevska
Copy link
Contributor Author

elena-kolevska commented Mar 6, 2024

Since version 0.3.0 the ruff autoformatter conflicts with flake8. I think this is something we have to make a decision on and send a separate PR for.

@berndverst
Copy link
Member

I pinned 0.2.2 now and updated your PR

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release-1.13@06e1587). Click here to learn what that means.

Additional details and impacted files
@@               Coverage Diff               @@
##             release-1.13     #683   +/-   ##
===============================================
  Coverage                ?   86.19%           
===============================================
  Files                   ?       82           
  Lines                   ?     4172           
  Branches                ?        0           
===============================================
  Hits                    ?     3596           
  Misses                  ?      576           
  Partials                ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elena-kolevska elena-kolevska changed the title Brings back the link that was removed because it wasn’t online yet Brings back a link that was removed because it wasn’t online yet Mar 6, 2024
@elena-kolevska elena-kolevska changed the title Brings back a link that was removed because it wasn’t online yet Brings back a docs link that was removed because it wasn’t online yet Mar 6, 2024
@berndverst berndverst merged commit ae37977 into dapr:release-1.13 Apr 30, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants