Bidirectional streaming for pubsub #735
Open
+907
−248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elena-kolevska
changed the title
Signed-off-by: Elena Kolevska <elena@kolevska.com> fixes typing Signed-off-by: Elena Kolevska <elena@kolevska.com> more readable example Signed-off-by: Elena Kolevska <elena@kolevska.com> linter Signed-off-by: Elena Kolevska <elena@kolevska.com>
elena-kolevska
force-pushed
the
bidistreaming
branch
from
f64334f
to
fbd12a7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #735 +/- ##
==========================================
- Coverage 86.63% 86.33% -0.30%
==========================================
Files 84 85 +1
Lines 4473 4654 +181
==========================================
+ Hits 3875 4018 +143
- Misses 598 636 +38 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Elena Kolevska <elena@kolevska.com>
Signed-off-by: Elena Kolevska <elena@kolevska.com>
|
I haven't added docs still, but wanted to open the PR for review already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds bidirectional streaming support for pub sub.
Issue reference
#730
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: