Couple doc updates #101
Merged
Couple doc updates #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cscetbon
approved these changes
Feb 18, 2024
|
@yaron2 ready for your approval |
|
@calebcartwright could you please resolve the conflict |
|
Will close #78 |
|
Will do so later today, apologies for the delay |
Signed-off-by: Caleb Cartwright <caleb.cartwright@outlook.com>
Signed-off-by: Caleb Cartwright <caleb.cartwright@outlook.com>
calebcartwright
force-pushed
the
docs-updates
branch
from
6231e56
to
1fcb3e1
Compare
mikeee
approved these changes
Mar 14, 2024
|
I almost forgot to say thank you to you @calebcartwright for raising the PR and bringing clarity to the docs. Much appreciated! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two minor suggested updates to the docs:
prostno longer bundlesprotocand will no longer attempt to download the compiler if one doesn't already exist. Users will need protoc installed to work with the SDK so worth noting that as a pre-req IMOvendordirectory for 3rd party Go modules which seemed out of place to me and a potential copy/paste leftover from another repoNote that I opted to make these separate commits particularly in case I'm missing some context around that
vendordirectory and 6231e56 is not desired, but I can certainly squash the changes together if you'd prefer both in a single commit