You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
v := fmt.Sprintf("%v", src)
if v == "TestIssue106" {
fmt.Println(mustSet)
fmt.Println(dst.CanSet())
}
This is the only place the text "TestIssue106" occurs in this codebase (confirmed via find . -type f | xargs grep "TestIssue106"). I suspect this is leftover from a recent testing refactor. The conditional isn't so bad, but the Sprintf overhead adds up for large structs. In addition to the possibility for unexpected prints if someone's struct happens to contain that string...
This code is unused and should be removed.
The text was updated successfully, but these errors were encountered:
Thanks for opening a new issue. The team has been notified and will review it as soon as possible.
For urgent issues and priority support, visit https://xscode.com/imdario/mergo
bionoren
added a commit
to modopayments/mergo
that referenced
this issue
Aug 11, 2020
As of this writing, merge.go:274-278 read thus:
This is the only place the text "TestIssue106" occurs in this codebase (confirmed via
find . -type f | xargs grep "TestIssue106"
). I suspect this is leftover from a recent testing refactor. The conditional isn't so bad, but the Sprintf overhead adds up for large structs. In addition to the possibility for unexpected prints if someone's struct happens to contain that string...This code is unused and should be removed.
The text was updated successfully, but these errors were encountered: