Map Recursion issue #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR 8 (with MergeWithOverwrite) solves this issue. |
|
I read your message. Thanks for contacting. I'm under a heavy load of work and I'm not able to pull all the requests but I will try to check them this week. |
|
Any news ?:D |
|
Nope, sorry. I'm under a lot of pressure and I have little time for anything else. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a test that exposes an issue I'm running into with recursive map merges. I was expecting the merge to copy values from the
srcto thedstrecursively, overwriting existing values. That doesn't appear to be the case. Top level values are being overwritten but "deeper" values are not.In the test in this example you can see that the
KeyValuemap fromais merged intobbut values are not overwritten ifbis already set e.g.b.KeyValue["Key1"]should be getting set to"not value 1"Is this a bug or is it functioning as designed?