Overwrite struct's field with corresponding map's key that is intended to be zero #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow to overwrite struct field with empty value in case corresponding source map's key exists and indicated to zero-value
requilence
changed the title
luisdavim
approved these changes
Nov 3, 2018
|
Checking if it passes all the tests. |
|
It works. Merged. |
liggitt
reviewed
Apr 15, 2021
| @@ -72,6 +72,7 @@ func deepMap(dst, src reflect.Value, visited map[uintptr]*visit, depth int, conf | |||
| case reflect.Struct: | |||
| srcMap := src.Interface().(map[string]interface{}) | |||
| for key := range srcMap { | |||
| config.overwriteWithEmptyValue = true | |||
There was a problem hiding this comment.
if the continue or return cases are hit below without calling deepMerge (which would have reset to false), this results in mutating config and setting overwriteWithEmptyValue=true that can affect other calls to deepMerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details here: #84
In order to make deepMerge func know that it the src value was specially indicated in the source map(key exists) we need to pass some flag to it. And set this flag in case deepMerge while going through the source map keys.
One variant is to Implement unexported overwriteWithEmptyValue in the Config. So there is no need to extend deepMerge.
I have also wrote some basic tests