Proposal for 4.2.3 #108
Open
Proposal for 4.2.3 #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use different compat files to handle the different version of the parsetree, here the only difference are the string constants.
fix treatment of socket path passed in env variable PGHOST
[PPX DEPS] relax ppxlib constraint
|
@darioteixeira (I saw you're not watching the repository, so I hl you as you may not see the PR otherwise...) |
darioteixeira
approved these changes
Jun 2, 2021
| (preprocess (pps ppx_optcomp ppxlib.metaquot)) | ||
| (libraries ppxlib pgocaml) | ||
| (modules ppx_pgsql)) | ||
| (* -*- tuareg -*- *) |
There was a problem hiding this comment.
I don't think this line belongs here... ;-)
| (modules ppx_pgsql)) | ||
| (* -*- tuareg -*- *) | ||
|
|
||
| let () = |
There was a problem hiding this comment.
I didn't know that Dune supported dynamic generation of dune files from OCaml code, but it's a pretty cool feature!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes a version 4.2.3 including:
I was planning to submit it on opam-repo if there is no activity here...