refactor: provide topic in pubsub event #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
Ipfs::pubsub_eventswould providePubsubEventthat would only provide the peer id related to the topic where the events are being listened on, however there was no. way to listen on all pubsub sub/unsub events. This PR changes it to allow there to be an optional topic filter so if a topic is not supplied, it would listen on all pubsub events, including the topic inPubsubEvent. If a topic is supplied, it will only emit events related to that topic, however the topic would be excluded from the event, assuming that the caller would perform their own tracking (ie usingStreamMap, or their own preference when polling the stream).