Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Return events from gossipsub stream #68

Merged
merged 4 commits into from
May 3, 2023

Conversation

dariusc93
Copy link
Owner

Previously, we would checking to see if the peer is actually subscribed and adding or removing them without returning the event, which made it impossible to track subscribing and unsubscribing events from the swarm. This will remove those checks, which may have been redundant, and return the event while polling the behaviour.

@dariusc93 dariusc93 marked this pull request as ready for review May 3, 2023 15:24
@dariusc93 dariusc93 merged commit f7b0f74 into libp2p-next May 3, 2023
@dariusc93 dariusc93 deleted the fix/gossipsub-event branch May 3, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant