Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSP: Improve Hover Support to Show Helpful Information #5425

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

OceanOak
Copy link
Collaborator

@OceanOak OceanOak commented Oct 29, 2024

No changelog

This PR builds on the work started in #5422 to add Hover support to the language server, along with miscellaneous WT changes and parser fixes.

@OceanOak OceanOak force-pushed the more-lsp branch 6 times, most recently from 14df436 to f72b486 Compare November 5, 2024 12:44
@OceanOak OceanOak force-pushed the more-lsp branch 7 times, most recently from 37857f9 to 6714dc6 Compare November 8, 2024 13:09
@OceanOak OceanOak changed the title WIP: LSP hover LSP: Improve Hover Support to Show Helpful Information Nov 8, 2024
@OceanOak
Copy link
Collaborator Author

OceanOak commented Nov 13, 2024

TODOs that can be tackled in this PR or in a follow-up

  • show better hover information for (dictionary keys, record field names, enum case names, let patterns, and Builtin functions)
  • Retrieve the underlying type for alias chains
  • Escape early by checking if the range is outside the bounds of the full range
  • extract more helper functions

@OceanOak OceanOak marked this pull request as ready for review November 13, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant