New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: writtenTypes refactors #5426

Draft

OceanOak wants to merge 1 commit into darklang:main from OceanOak:refactor-attempt

Collaborator

OceanOak commented Nov 1, 2024

This is an attempt to refactor WrittenTypes to reduce redundancy when handling SubModules.

This isn't fully working yet; I still have to resolve an issue where an extra module with an empty name appears at the root level
Example:

module = 
  module MyModule1 =
    type ID1 = Int64
    module MyModule2 =
      type ID2 = Int64
      module MyModule3 =
        type ID3 = Int64

It might be good to see if there’s a better shape for the types before solving this issue

wip

b202517

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet