Feature/sanitizer #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added DefaultTextSanitizer to use a singleton pattern, ensuring only one instance is created and reused. - Added singleton pattern for DefaultHtmlSanitizer using bluemonday for robust HTML sanitization. - Added singleton pattern for NonSanitator, which returns input text unchanged. - Updated tests to cover new singleton implementations, ensuring thorough test coverage and security. This update ensures efficient memory management and prevents tampering with the default sanitators, enhancing security and performance.
…comprehensive tests - Added and methods to to allow for custom sanitization of email content. - Enhanced documentation for all sanitizers and updated EmailMessage methods to include warnings about custom sanitizers. - Implemented checks for custom sanitizers in , , and methods. - Updated and to use default text sanitizer if custom sanitizer is not set. - Added and enhanced tests to cover new functionalities and edge cases This commit enhances the security and flexibility of the struct by allowing custom sanitization strategies while maintaining comprehensive test coverage.
JRocabruna
added
enhancement
DarkRockMountain-admin
approved these changes
Jun 19, 2024
There was a problem hiding this comment.
Comments
The changes introduced in this pull request enhance the EmailMessage struct by adding custom sanitizers for text and HTML content, improving flexibility and security. The updates are well-documented and include comprehensive tests to ensure robustness.
Review Checklist
- Code adheres to the project's coding guidelines.
- Changes are well-documented.
- Tests have been added/updated and pass successfully.
- Commit messages follow the correct format:
type(scope): description. - No conflicts with the base branch.
Approval
Approved: Changes look good and meet the project's contribution standards.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces custom sanitizers for text and HTML content within the
EmailMessagestruct. Users can now specify their own sanitization logic or utilize the default sanitizers provided. This enhancement improves flexibility and security in email content handling. The changes also include comprehensive tests to ensure robust functionality and edge case coverage.Checklist
type(scope): description.Additional Information
This update includes:
SetCustomTextSanitizerandSetCustomHtmlSanitizer.