Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Enhance CI run and make mac ci less likely to fail #7561

Merged
merged 10 commits into from
Dec 31, 2020

Conversation

johnny-bit
Copy link
Member

I tried here to work around the CI issues with mac on gh actions workers - turns out it's recent python 3.9 change :/ For some it's automagically fixed, for others not... So i had to use a workaround

Additionally:

  • Adds GCC 7 builds - since we kinda support Ubuntu LTS 18.04 & 20.04, right?
  • Adds nofeatures_nosse target to check whether something won't blow up if there's no SSE
  • with Linux-minimal checking "basic compilers" all probable failures are checked early and so Linux, Windows & Mac targets are checked in parallel.

This should make it easier to catch if PR is failing due to code rather than OS/Packaging problems

sidenote: msys2 still can fail with weird stuff. No workarounds for that except "try to restart action every 2-4 hours" :/

@MStraeten
Copy link
Collaborator

did set up the homebrew way of build according to the ci description in #7564 (comment) in a osx virtual machine (mojave, sdk 10.14) and darktable-3.4.x branch was built fine ...

@johnny-bit
Copy link
Member Author

Yeah. That's why I needed to make a workaround for gh actions - this is workaround + beefing up ;)

@TurboGit
Copy link
Member

@johnny-bit : the windows failures are transients or really something to look at ? Some packages not updated...

@johnny-bit
Copy link
Member Author

the windows failures are transients or really something to look at?

According to msys2 folks - "sync issues on mirrors, usually gone in 15-30 mins, sometimes more"

@TurboGit
Copy link
Member

Ok, let's merge then. Thanks a lot for looking into this.

@TurboGit TurboGit merged commit 5d995b4 into darktable-org:master Dec 31, 2020
@TurboGit TurboGit added this to the 3.6 milestone Dec 31, 2020
@TurboGit TurboGit self-requested a review December 31, 2020 08:31
@johnny-bit
Copy link
Member Author

"Current" msys2 issues are in this ticket: msys2/setup-msys2#99

@johnny-bit johnny-bit deleted the darktable-fixmacci branch December 31, 2020 09:42
@parafin
Copy link
Member

parafin commented Dec 31, 2020

Probably worth merging into 3.4 branch too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants