Skip to content

Commit

Permalink
doc: banman: reference past vuln due to unbounded banlist
Browse files Browse the repository at this point in the history
  • Loading branch information
darosior committed Jul 28, 2024
1 parent 70992f5 commit 7fea8ee
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions src/banman.h
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,11 @@ class CSubNet;
// transaction that fails a policy check and a future version changes the
// policy check so the transaction is accepted, then that transaction could
// cause the network to split between old nodes and new nodes.
//
// NOTE: previously a misbehaving peer would get banned instead of discouraged.
// This meant a peer could unboundedly grow our in-memory map of banned ips. When
// receiving an ADDR message we would also compare every address received to every
// item in the map. See https://bitcoincore.org/en/2024/07/03/disclose-unbounded-banlist.

class BanMan
{
Expand Down

0 comments on commit 7fea8ee

Please sign in to comment.