Add number_format function to all prices #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebisbe
commented
Oct 26, 2016
| @@ -12,7 +12,7 @@ | |||
| "require": { | |||
| "php": ">=5.4.0", | |||
| "illuminate/support": "5.0.*|5.1.*|5.2.*|5.3.*", | |||
| "illuminate/validation": "5.0.*|5.1.*|5.2.*|5.3.*" | |||
| "illuminate/validation": "5.0.*|5.1.*|5.2.*|5.3.4" | |||
There was a problem hiding this comment.
There's a bug with versions > 5.3.4 laravel/framework#16078
|
Hello @darryldecode, Can you merge my PR?? |
|
👍 |
|
@darryldecode @ebisbe Can you please revert this, my whole app is not working anymore... see this issue #74 |
|
You can define how many decimals you want to use. I have to write the documentation... Add this to your .env file |
|
Let's continue this conversation in issue #74 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now all prices shown by Cart and ItemCollection can be formated as desired. I've just wrapper for number_format() with a configuration file to configure it.
http://php.net/manual/en/function.number-format.php