Update to latest lints, require Dart 3.3 #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also enable CI on main branch
devoncarew
approved these changes
Apr 17, 2024
| @@ -9,8 +9,8 @@ topics: | |||
| - cli | |||
|
|
|||
| environment: | |||
| sdk: ^3.0.0 | |||
| sdk: ^3.3.0 | |||
There was a problem hiding this comment.
Do we really need as late as 3.3?
There was a problem hiding this comment.
In my mind: it hurts NOTHING. Makes sure we're getting access to latest language features. Given how quickly our ecosystem moves forward, etc.
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
May 20, 2024
Revisions updated by `dart tools/rev_sdk_deps.dart`. args (https://github.com/dart-lang/args/compare/5c83bc9..cf90551): cf90551 Fri May 3 11:17:38 2024 -0700 Devon Carew blast_repo fixes (dart-lang/args#274) 72d6ef0 Wed May 1 23:57:25 2024 +0000 dependabot[bot] Bump actions/checkout from 4.1.2 to 4.1.4 (dart-lang/args#271) e2e2023 Wed Apr 17 15:00:21 2024 -0700 Kevin Moore Update to latest lints, require Dart 3.3 (dart-lang/args#270) 8d66d21 Mon Apr 15 15:29:55 2024 +0000 dependabot[bot] Bump dart-lang/setup-dart from 1.6.2 to 1.6.4 (dart-lang/args#268) http (https://github.com/dart-lang/http/compare/76deb75..5c01453): 5c01453 Fri May 17 15:41:46 2024 -0700 Brian Quinlan Create a fake WebSocket implementation (dart-lang/http#1200) 4d2f9f9 Fri May 17 15:19:58 2024 -0700 Brian Quinlan Get ready to publish cronet_http 1.2.1 (dart-lang/http#1202) mockito (https://github.com/dart-lang/mockito/compare/4be52e1..2302814): 2302814 Fri May 17 09:51:20 2024 -0700 Googler Stop using deprecated LibraryElement.isNonNullableByDefault web_socket_channel (https://github.com/dart-lang/web_socket_channel/compare/8c77d6f..45b8ce9): 45b8ce9 Fri May 17 15:19:29 2024 -0700 Brian Quinlan Remove obsolete `WebSocketChannel.new` documentation. (dart-lang/web_socket_channel#363) Change-Id: I654b0dce548e8b4ca1b98a626fddcb071cb1daae Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/367147 Auto-Submit: Devon Carew <devoncarew@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.