-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider disabling by default or removing Chain.capture in build_runner #1039
Comments
+1 to remove |
Ya I am in favor of removing as well. |
We had some discussion where we assumed that this was mainly capturing stack traces for exceptions which happen within the build_runner package, not within builders. When I look at #448 and it's related issue #427 it points to this helping with stack traces from exceptions within builders. It's possible this is no longer the case if something has change in Worst case scenario is instead of remove it we default the The capture was added in #62 but there isn't discussion on why it was chosen instead of |
OK, I think #550 effectively shifts the responsibility into |
Closes #1039 The stack traces for exceptions within builders are now captured and logged from within `runBuilder`. The only exceptions that this chain would capture are bugs in the build_runner package. Removing the chaining shows a peformance improvement.
Closes #1039 The stack traces for exceptions within builders are now captured and logged from within `runBuilder`. The only exceptions that this chain would capture are bugs in the build_runner package. Removing the chaining shows a performance improvement.
build/build_runner/lib/src/generate/build_impl.dart
Line 265 in 42c4fde
In one case, seems to add 8% to build times
The text was updated successfully, but these errors were encountered: