add some basic build tests to get started, as well as a basic test framework #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var packageNode = packageGraph[inputSet.package]; | ||
| var packagePath = packageNode.location.toFilePath(); | ||
| for (var glob in inputSet.globs) { | ||
| var files = glob.listSync(followLinks: false, root: packagePath).where( |
There was a problem hiding this comment.
might not matter, but I guess you could do this async, given that you are already in an async* method?
|
just minor suggestions, ow lgtm |
kevmoo
added
type-enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also snuck in a needed update to
AssetReader, which lets you list files matching a list ofInputSets. This was the last step needed to have a fully injectable asset system.