Add incremental builds on startup using cached dependency graph #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -40,18 +40,18 @@ class AssetCache { | |||
| /// will first look up values in the [AssetCache], and if not present it will | |||
| /// use the [AssetReader] and add the [Asset] to the [AssetCache]. | |||
| class CachedAssetReader extends AssetReader { | |||
| final AssetCache _cache; | |||
| final AssetCache cache; | |||
There was a problem hiding this comment.
Consider adding an evict or remove method to the CachedAssetReader rather than exposing the cache itself.
There was a problem hiding this comment.
good call, adding evictFromCache method
|
LGTM |
jakemac53
force-pushed
the
use-last-modified
branch
from
d7e8063 to
c0b6283
Compare
kevmoo
added
type-enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.