Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add links to the package issue trackers #720

Merged
merged 1 commit into from
Nov 7, 2024
Merged

add links to the package issue trackers #720

merged 1 commit into from
Nov 7, 2024

Conversation

devoncarew
Copy link
Member

  • add links to the package issue trackers in the main readme
  • add links to the package issue trackers in the pubspec files (populate the issue_tracker field)
  • minor normalization of other repo files

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Copy link

github-actions bot commented Nov 7, 2024

Package publishing

Package Version Status Publish tag (post-merge)
package:characters 1.4.0 ready to publish characters-v1.4.0
package:args 2.6.1-wip WIP (no publish necessary)
package:async 2.12.0 already published at pub.dev
package:collection 1.19.1-wip WIP (no publish necessary)
package:convert 3.1.2 already published at pub.dev
package:crypto 3.0.6 already published at pub.dev
package:fixnum 1.1.1 already published at pub.dev
package:logging 1.3.0 already published at pub.dev
package:os_detect 2.0.3-wip WIP (no publish necessary)
package:path 1.9.1 already published at pub.dev
package:platform 3.1.6 already published at pub.dev
package:typed_data 1.4.0 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

Copy link

github-actions bot commented Nov 7, 2024

PR Health

Coverage ✔️
File Coverage

This check for test coverage is informational (issues shown here will not fail the PR).

API leaks ⚠️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
path InternalStyle

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

@devoncarew
Copy link
Member Author

Skipping the changelog check; we'll capture the issue_tracker pubspec change organically w/ the next update to each package.

@devoncarew
Copy link
Member Author

devoncarew commented Nov 7, 2024

The health check failure here may be related to the api diff tool:

Look for changes in package:fixnum 1.1.1 (dir=/home/runner/work/core/core/current_repo/pkgs/fixnum) with base Directory: '../base_repo'
Error: Error while creating the diff: Bad state: Too many elements
#0      Iterable.single (dart:core/iterable.dart:677:24)
#1      PackageApiDiffer._diffIterables (package:dart_apitool/src/diff/package_api_differ.dart:1344:45)
#2      PackageApiDiffer._calculateExecutablesDiff (package:dart_apitool/src/diff/package_api_differ.dart:266:32)
#3      PackageApiDiffer._calculateInterfaceDiff.<anonymous closure> (package:dart_apitool/src/diff/package_api_differ.dart:180:12)
#4      PackageApiDiffer._executeInContext (package:dart_apitool/src/diff/package_api_differ.dart:1263:23)
#5      PackageApiDiffer._calculateInterfaceDiff (package:dart_apitool/src/diff/package_api_differ.dart:175:12)
#6      PackageApiDiffer._calculateInterfacesDiff (package:dart_apitool/src/diff/package_api_differ.dart:137:22)
#7      PackageApiDiffer.diff (package:dart_apitool/src/diff/package_api_differ.dart:47:12)
#8      DiffCommand.run (package:dart_apitool/src/cli/commands/diff_command.dart:188:16)
<asynchronous suspension>
#9      CommandRunner.runCommand (package:args/command_runner.dart:212:13)
<asynchronous suspension>
#10     main (file:///home/runner/.pub-cache/hosted/pub.dev/dart_apitool-0.20.0/bin/main.dart:28:22)

@devoncarew devoncarew requested a review from natebosch November 7, 2024 19:38
@devoncarew devoncarew merged commit 6af0821 into main Nov 7, 2024
56 of 59 checks passed
@devoncarew devoncarew deleted the issue_links branch November 7, 2024 20:09
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Nov 11, 2024
Revisions updated by `dart tools/rev_sdk_deps.dart`.

core (https://github.com/dart-lang/core/compare/1156cfe..6af0821):
  6af0821d  2024-11-07  Devon Carew  add links to the package issue trackers (dart-lang/core#720)

Change-Id: I29a8a64b81a3159dc2ca7dd8d07056bc7c0061ce
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394402
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants