Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vm_service 2.1.2 breaks coverage 0.13.3+1 #458

Closed
mmcc007 opened this issue Nov 30, 2019 · 8 comments · Fixed by dart-archive/coverage#280
Closed

vm_service 2.1.2 breaks coverage 0.13.3+1 #458

mmcc007 opened this issue Nov 30, 2019 · 8 comments · Fixed by dart-archive/coverage#280
Assignees
@cbracken
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures package:coverage type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@mmcc007
Copy link

mmcc007 commented Nov 30, 2019

A recent upgrade of vm_service breaks coverage 0.13.3+1 (used to use vm_service 2.1.1). Reverting to coverage 0.13.3 resolves it for now (vm_service 1.2.0).
@cbracken cbracken added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) P1 A high priority bug; for example, a single project is unusable or has many test failures labels Dec 2, 2019
@cbracken cbracken self-assigned this Dec 2, 2019
@cbracken
Copy link
Member

cbracken commented Dec 2, 2019

/cc @bkonyi looks like the issue originated with publishing 2.1.2 without the minimum Dart SDK constraint bumped to a version that includes support for the IsolateGroups work that landed in dart-lang/sdk@9e636b5.

@cbracken
Copy link
Member

cbracken commented Dec 2, 2019

Discussed in person with @bkonyi. He's going to:

  1. Publish vm_service 2.1.3 that has dart-lang/sdk@9e636b5 reverted. Since the current stable SDK doesn't yet include the IsolateGroup work, this'll fix anyone broken by that change.
  2. Reland dart-lang/sdk@9e636b5 and publish a new vm_service release (2.2.0 maybe?) with a new SDK constraint that starts at whichever dev SDK first includes that support.

In the meantime, I'm going to quick publish a version of coverage with an upper bound of <2.1.2 for vm_service to unbreak current users.

@mmcc007
Copy link
Author

mmcc007 commented Dec 3, 2019

Thanks for the quick response.

@cbracken cbracken mentioned this issue Dec 3, 2019
Merged
@cbracken
Copy link
Member

cbracken commented Dec 3, 2019

dart-archive/coverage#279 has landed which sets the upper bound on the vm_service constraint to <2.1.2 and has been published in version 0.13.3+2.

Once items 1 and 2 have landed in the Dart SDK, I'll republish this package with an updated vm_service dependency.

@cbracken cbracken closed this as completed Dec 3, 2019
@cbracken cbracken reopened this Dec 3, 2019
@cbracken
Copy link
Member

cbracken commented Dec 3, 2019 •
edited
Loading

Re-opening since there's still work to do for the long-term fix. :)

@cbracken
Copy link
Member

cbracken commented Dec 3, 2019 •
edited
Loading

@mmcc007 thanks for reporting this!

Please shout if you find the latest version on pub isn't working for you. @bkonyi mentioned it'll probably be a couple of days before he's able to get the upstream fixes landed in vm_service, but we'll try to get the long-term fix landed as quickly as possible.

@mmcc007
Copy link
Author

mmcc007 commented Dec 3, 2019

Will do. Thanks for the thorough support!

@bkonyi
Copy link
Contributor

bkonyi commented Dec 3, 2019

A fix for package:vm_service is up for review here: https://dart-review.googlesource.com/c/sdk/+/127065

dart-bot referenced this issue in dart-lang/sdk Dec 3, 2019
@bkonyi
[ package:vm_service ] Fix issue where an exception could be thrown i…
7a911ce 
…f remote service protocl version was older than that supported by package:vm_service

When connecting to a VM service which supports an older version of the
protocol than that supported by package:vm_service, there was the
possibility for a crash if the package tried to create a List for a
response property which is not supported by the remote VM service. The
fix here is to check for null from createServiceObject when building a
List from a response and produce an empty list for that property.

Issue originally filed here: https://github.com/dart-lang/coverage/issues/278

Change-Id: Ibe8593fa8e4a55d05dd821bbdf363a67c15d5483
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127065
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
bkonyi referenced this issue in dart-archive/coverage Dec 3, 2019
@bkonyi
Loosen version restriction on package:vm_service now that crasher has
2e2f1e2 
been fixed

See dart-lang/sdk@7a911ce

Fixes https://github.com/dart-lang/coverage/issues/278
@bkonyi bkonyi mentioned this issue Dec 3, 2019
Merged
cbracken referenced this issue in dart-archive/coverage Dec 4, 2019
@bkonyi @cbracken
Loosen version restriction on package:vm_service (#280)
5880488 
Re-loosen the dependency on the `vm_service` package from `>=1.0.0 < 2.1.2`
to `>=1.0.0 <3.0.0` now that breakage introduced in version `2.1.2` has been
resolved. Fixed in:
dart-lang/sdk@7a911ce.

Fixes https://github.com/dart-lang/coverage/issues/278.
mosuem referenced this issue in mosuem/tools_fork Aug 9, 2024
@bkonyi @cbracken
Loosen version restriction on package:vm_service (dart-lang#280)
710011e 
Re-loosen the dependency on the `vm_service` package from `>=1.0.0 < 2.1.2`
to `>=1.0.0 <3.0.0` now that breakage introduced in version `2.1.2` has been
resolved. Fixed in:
dart-lang/sdk@7a911ce.

Fixes https://github.com/dart-lang/coverage/issues/278.
mosuem referenced this issue Aug 28, 2024
@bkonyi @cbracken
Loosen version restriction on package:vm_service (dart-archive/covera…
0434e33 
…ge#280)

Re-loosen the dependency on the `vm_service` package from `>=1.0.0 < 2.1.2`
to `>=1.0.0 <3.0.0` now that breakage introduced in version `2.1.2` has been
resolved. Fixed in:
dart-lang/sdk@7a911ce.

Fixes https://github.com/dart-lang/coverage/issues/278.
@mosuem mosuem transferred this issue from dart-archive/coverage Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cbracken cbracken

Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures package:coverage type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
4 participants
@cbracken @mmcc007 @bkonyi @mosuem