Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@hideConstantImplementations by default. #3576

Merged
merged 5 commits into from
Nov 16, 2023
Merged

@hideConstantImplementations by default. #3576

merged 5 commits into from
Nov 16, 2023

Conversation

kallentu
Copy link
Member

@kallentu kallentu commented Nov 10, 2023

@hideConstantImplementations is now removed and applied by default where it was checked before.
Updated the tests and moved them to the constant_values_test.dart file.
Removed that directive information on the README.

Bug: #3564.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Copy link
Member

@srawlins srawlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@srawlins
Copy link
Member

Flutter has a check for non-replaced doc directives, as seen in the CI. I think we can just remove that directive from flutter, and then land this, and then cut a release.

@kallentu
Copy link
Member Author

Sounds good, I'm on it.

@kallentu
Copy link
Member Author

@srawlins Okay, took a while to figure out what flutter needs to pass lol. The PR currently parses and hides the hideConstantImplementations directive, but it's not useful.
PTAL and I'll submit, cut a release, make a Flutter PR removing the directive usages + bumping the version and come back to delete this directive fully.

Copy link
Member

@srawlins srawlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This is perfect.

@kallentu kallentu merged commit 766a9b4 into main Nov 16, 2023
11 checks passed
@kallentu kallentu deleted the hideConstantImpl branch November 16, 2023 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants