New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missed commit on feedback fo options_test #3587

Merged

srawlins merged 1 commit into dart-lang:main from srawlins:whoops-commit

Nov 23, 2023

Member

srawlins commented Nov 22, 2023

I’ve reviewed the contributor guide and applied the relevant portions to this PR.

Contribution guidelines:

See our contributor guide for general expectations for PRs.
Larger or significant changes should be discussed in an issue before creating a PR.
Contributions to our repos should follow the Dart style guide and use dart format.
Most changes should add an entry to the changelog and may need to rev the pubspec package version.
Changes to packages require corresponding tests.

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.


          Missed commit on feedback fo options_test

5b1dc26

srawlins requested a review from kallentu

November 22, 2023 13:19

kallentu approved these changes

View reviewed changes

srawlins merged commit 7c2d9f0 into dart-lang:main

9 checks passed

srawlins deleted the whoops-commit branch

November 23, 2023 15:42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet