Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace record keys in maps #3659

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

jensjoha
Copy link
Contributor

Something weird is happening - for dart JIT - when using records as keys in maps. See also dart-lang/sdk#54928 where I reported it as a bug.

This PR uses 2 classes instead.
The result - for a very small example - is:

Difference at 95.0% confidence
        -6286.33 +/- 969.339
        -29.6791% +/- 4.57645%
        (Student's t, pooled s = 427.663)

(from ~21 seconds to ~15 seconds)

and trying on flutter the result is

Difference at 95.0% confidence
        -46593 +/- 2604.32
        -37.4728% +/- 2.09454%
        (Student's t, pooled s = 1149)

(from ~124 seconds to ~78 seconds)

There is ~no difference for an AOT compile.

@srawlins
Copy link
Member

Thanks for the great analysis, @jensjoha! The gardeners had noticed the dart doc test taking a long time as well, and filed dart-lang/sdk#53278, which I have not looked at in a while. I'll land this change and watch that bot.

Copy link
Member

@srawlins srawlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very straightforward, thanks for the fix!

@srawlins srawlins merged commit 5b1a9dd into dart-lang:main Feb 16, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants