New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove missingConstantConstructor warning. #3674

Merged

kallentu merged 1 commit into main from missing-constant-ctor

Feb 23, 2024

Member

kallentu commented Feb 23, 2024

Don't warn on a missing constant constructor.
Cleaning up the warning because we most likely don't need it and the analyzer for sure reports this.

I’ve reviewed the contributor guide and applied the relevant portions to this PR.

Contribution guidelines:

See our contributor guide for general expectations for PRs.
Larger or significant changes should be discussed in an issue before creating a PR.
Contributions to our repos should follow the Dart style guide and use dart format.
Most changes should add an entry to the changelog and may need to rev the pubspec package version.
Changes to packages require corresponding tests.

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.


          Remove missingConstantConstructor warning.

074fe37

kallentu requested a review from srawlins

February 23, 2024 16:11

srawlins approved these changes

View reviewed changes

Member

srawlins left a comment

LGTM

kallentu merged commit e01eab3 into main

11 checks passed

kallentu deleted the missing-constant-ctor branch

February 23, 2024 17:18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet