Skip to content

Commit

Permalink
[dart_flutter_team_lints] add strict_top_level_inference (#328)
Browse files Browse the repository at this point in the history
- add the new `strict_top_level_inference` lint
- update the sdk dependency
- rev for publishing

Note that this won't build cleanly until a dev sdk is released that
contains `strict_top_level_inference`; I'll hold off on landing /
publishing this until then.

w/ the pubspec constraints here:
- most packages using this (^3.0.0) will solve for this new version of
the package
- they'll only get this version if they happen to be running `pub get`
on a 3.7 dev version of the sdk
- many repos in dart-lang will pick up this version, but only from the
build jobs running on a dev sdk

I think we can publish this and fix up the failing jobs reactively.

---

- [x] I’ve reviewed the contributor guide and applied the relevant
portions to this PR.

<details>
  <summary>Contribution guidelines:</summary><br>

- See our [contributor
guide](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md)
for general expectations for PRs.
- Larger or significant changes should be discussed in an issue before
creating a PR.
- Contributions to our repos should follow the [Dart style
guide](https://dart.dev/guides/language/effective-dart) and use `dart
format`.
- Most changes should add an entry to the changelog and may need to [rev
the pubspec package
version](https://github.com/dart-lang/sdk/blob/main/docs/External-Package-Maintenance.md#making-a-change).
- Changes to packages require [corresponding
tests](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md#Testing).

Note that many Dart repos have a weekly cadence for reviewing PRs -
please allow for some latency before initial review feedback.
</details>
  • Loading branch information
devoncarew authored Dec 20, 2024
1 parent 38897ae commit d42c4d2
Show file tree
Hide file tree
Showing 6 changed files with 15 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/dart_flutter_team_lints.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
strategy:
fail-fast: false
matrix:
sdk: [stable, dev]
sdk: [dev] # TODO: add back in stable
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
- uses: dart-lang/setup-dart@e630b99d28a3b71860378cafdc2a067c71107f94
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/health_internal.yaml
Original file line number Diff line number Diff line change
@@ -1,14 +1,17 @@
# A CI configuration to check PR health.

name: Health:Internal

on:
pull_request:
branches: [ main ]
types: [opened, synchronize, reopened, labeled, unlabeled]

jobs:
health:
uses: ./.github/workflows/health.yaml
with:
sdk: dev
local_debug: true
coverage_web: false
upload_coverage: false
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/publish_internal.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,19 @@
# publishing code at head.

name: Publish:Internal

on:
pull_request:
branches: [ main ]
types: [opened, synchronize, reopened, labeled, unlabeled]
push:
tags: [ '[A-z]+-v[0-9]+.[0-9]+.[0-9]+*' ]

jobs:
publish:
uses: ./.github/workflows/publish.yaml
with:
local_debug: true
use-flutter: false
write-comments: false
sdk: dev
5 changes: 5 additions & 0 deletions pkgs/dart_flutter_team_lints/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## 3.3.0

- Added `strict_top_level_inference`.
- Require Dart `3.7`.

## 3.2.1

- Depend on the `5.0.0` release of `package:lints`.
Expand Down
1 change: 1 addition & 0 deletions pkgs/dart_flutter_team_lints/lib/analysis_options.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ linter:
- comment_references
- conditional_uri_does_not_exist
- only_throw_errors
- strict_top_level_inference
- test_types_in_equals
- throw_in_finally
- type_annotate_public_apis
Expand Down
4 changes: 2 additions & 2 deletions pkgs/dart_flutter_team_lints/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
name: dart_flutter_team_lints
description: An analysis rule set used by the Dart and Flutter teams.
version: 3.2.1
version: 3.3.0
repository: https://github.com/dart-lang/ecosystem/tree/main/pkgs/dart_flutter_team_lints

environment:
sdk: ^3.5.0
sdk: ^3.7.0-0

dependencies:
lints: ^5.0.0
Expand Down

0 comments on commit d42c4d2

Please sign in to comment.