-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to health.yaml
#310
Conversation
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
PR HealthBreaking changes ✔️
Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs.
Coverage
|
File | Coverage |
---|---|
pkgs/dart_flutter_team_lints/tool/dedup.dart | 💔 Not covered |
pkgs/firehose/bin/firehose.dart | 💔 Not covered |
pkgs/firehose/bin/health.dart | 💔 Not covered |
pkgs/firehose/lib/firehose.dart | 💔 0 % ⬇️ NaN % |
pkgs/firehose/lib/src/changelog.dart | 💚 100 % |
pkgs/firehose/lib/src/delayed_client.dart | 💚 23 % |
pkgs/firehose/lib/src/github.dart | 💚 68 % |
pkgs/firehose/lib/src/health/changelog.dart | 💚 97 % |
pkgs/firehose/lib/src/health/coverage.dart | 💔 76 % ⬇️ 1 % |
pkgs/firehose/lib/src/health/health.dart | 💔 92 % ⬇️ 3 % |
pkgs/firehose/lib/src/health/lcov.dart | 💚 89 % |
pkgs/firehose/lib/src/health/license.dart | 💚 100 % |
pkgs/firehose/lib/src/pub.dart | 💚 89 % |
pkgs/firehose/lib/src/repo.dart | 💔 91 % ⬇️ 2 % |
pkgs/firehose/lib/src/utils.dart | 💚 24 % |
pkgs/firehose/test_data/base_test_repo/pkgs/package1/bin/package1.dart | 💔 Not covered |
pkgs/firehose/test_data/base_test_repo/pkgs/package1/lib/package1.dart | 💔 Not covered |
pkgs/firehose/test_data/base_test_repo/pkgs/package1/test/package1_test.dart | 💔 Not covered |
pkgs/firehose/test_data/base_test_repo/pkgs/package2/bin/package2.dart | 💔 Not covered |
pkgs/firehose/test_data/base_test_repo/pkgs/package2/lib/package2.dart | 💔 Not covered |
pkgs/firehose/test_data/base_test_repo/pkgs/package2/test/package2_test.dart | 💔 Not covered |
pkgs/firehose/test_data/base_test_repo/pkgs/package3/bin/package3.dart | 💔 Not covered |
pkgs/firehose/test_data/base_test_repo/pkgs/package3/lib/package3.dart | 💔 Not covered |
pkgs/firehose/test_data/base_test_repo/pkgs/package3/test/package3_test.dart | 💔 Not covered |
pkgs/firehose/test_data/base_test_repo/pkgs/package5/lib/package5.dart | 💔 Not covered |
pkgs/firehose/test_data/base_test_repo/pkgs/package5/lib/src/package5_base.dart | 💔 Not covered |
pkgs/firehose/test_data/test_repo/pkgs/package1/bin/package1.dart | 💔 Not covered |
pkgs/firehose/test_data/test_repo/pkgs/package1/lib/package1.dart | 💔 Not covered |
pkgs/firehose/test_data/test_repo/pkgs/package1/test/package1_test.dart | 💔 Not covered |
pkgs/firehose/test_data/test_repo/pkgs/package2/bin/package2.dart | 💔 Not covered |
pkgs/firehose/test_data/test_repo/pkgs/package2/lib/anotherLib.dart | 💔 Not covered |
pkgs/firehose/test_data/test_repo/pkgs/package2/lib/package2.dart | 💔 Not covered |
pkgs/firehose/test_data/test_repo/pkgs/package2/test/package2_test.dart | 💔 Not covered |
pkgs/firehose/test_data/test_repo/pkgs/package3/bin/package3.dart | 💔 Not covered |
pkgs/firehose/test_data/test_repo/pkgs/package3/lib/package3.dart | 💔 Not covered |
pkgs/firehose/test_data/test_repo/pkgs/package3/test/package3_test.dart | 💔 Not covered |
pkgs/firehose/test_data/test_repo/pkgs/package5/lib/package5.dart | 💔 Not covered |
pkgs/firehose/test_data/test_repo/pkgs/package5/lib/src/package5_base.dart | 💔 Not covered |
This check for test coverage is informational (issues shown here will not fail the PR).
This check can be disabled by tagging the PR with skip-coverage-check
.
API leaks ✔️
The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
Package | Leaked API symbols |
---|
License Headers ✔️
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files |
---|
no missing headers |
All source files should start with a license header.
@@ -48,17 +48,23 @@ void main(List<String> arguments) async { | |||
..addFlag( | |||
'coverage_web', | |||
help: 'Whether to run web tests for coverage', | |||
) | |||
..addMultiOption( | |||
'flutter_packages', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see we're using a foo_bar
naming convention here and for the other options. I believe a foo-bar
convention is more common for args, but likely not worth changing here or being inconsistent w/ the other option names.
Co-authored-by: Devon Carew <devoncarew@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a breaking change, as the use-flutter argument is not existing anymore. After landing this, all dart-lang/ repos will have to be updated. As part of that update, we should maybe have the health.yamls depend on a hash instead of the main branch.
We won't break things much, and should be able to get down to just having ~a dozen repos to update; I think either referencing main
or a hash would work. We could also create releases, and then reference the more semantic tag (healthcheck-v0.2.0
). I don't think that would save us time however - for any change we wanted roll out we'd need to send PRs to all the monorepos.
Revisions updated by `dart tools/rev_sdk_deps.dart`. core (https://github.com/dart-lang/core/compare/abcf992..7f9f597): 7f9f597e 2024-12-03 Devon Carew update the pubspec version of package:collection (dart-lang/core#730) ecosystem (https://github.com/dart-lang/ecosystem/compare/248b180..b4b2a43): b4b2a43 2024-12-06 Moritz Unsubmit donotsubmit (dart-lang/ecosystem#324) 8749a2b 2024-12-06 Moritz Updates to `health.yaml` (dart-lang/ecosystem#310) 10fb2c0 2024-12-05 Moritz Ecosystem testing (dart-lang/ecosystem#320) test (https://github.com/dart-lang/test/compare/2096773..dc0f8ea): dc0f8ea4 2024-12-04 Nate Bosch Fix hang after multiple precompiled browser tests (dart-lang/test#2422) tools (https://github.com/dart-lang/tools/compare/1c5b8b9..223daf5): 223daf53 2024-12-05 Ben Konyi Update `package:vm_service` constraints to >=12.0.0 <16.0.0 (dart-lang/tools#1205) vector_math (https://github.com/google/vector_math.dart/compare/433fb6c..bd4b574): bd4b574 2024-12-09 Plague Fox Partial fix for benchmarks (google/vector_math.dart#337) Change-Id: Ie5ce1e95647ac19af1dcfd1d5ee495659052ddc9 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/399701 Reviewed-by: Nate Bosch <nbosch@google.com> Commit-Queue: Devon Carew <devoncarew@google.com>
This is a breaking change, as the
use-flutter
argument is not existing anymore. After landing this, alldart-lang/
repos will have to be updated. As part of that update, we should maybe have thehealth.yaml
s depend on a hash instead of themain
branch.Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.