Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to health.yaml #310

Merged
merged 34 commits into from
Dec 6, 2024
Merged

Updates to health.yaml #310

merged 34 commits into from
Dec 6, 2024

Conversation

mosuem
Copy link
Member

@mosuem mosuem commented Oct 24, 2024

  • Run health workflow on all packages if it is changed
  • Specify Flutter packages in the repo, to only have a single workflow file
  • Compare to last published version in breaking check.

This is a breaking change, as the use-flutter argument is not existing anymore. After landing this, all dart-lang/ repos will have to be updated. As part of that update, we should maybe have the health.yamls depend on a hash instead of the main branch.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@github-actions github-actions bot added the type-infra A repository infrastructure change or enhancement label Oct 24, 2024
Copy link

github-actions bot commented Oct 24, 2024

Package publishing

Package Version Status Publish tag (post-merge)
package:firehose 0.10.0 ready to publish firehose-v0.10.0
package:dart_flutter_team_lints 3.2.1 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

Copy link

github-actions bot commented Oct 24, 2024

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
dart_flutter_team_lints None 3.2.1 3.2.1 3.2.1 ✔️
firehose Breaking 0.9.3 0.10.0 0.10.0 ✔️
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ⚠️
File Coverage
pkgs/dart_flutter_team_lints/tool/dedup.dart 💔 Not covered
pkgs/firehose/bin/firehose.dart 💔 Not covered
pkgs/firehose/bin/health.dart 💔 Not covered
pkgs/firehose/lib/firehose.dart 💔 0 % ⬇️ NaN %
pkgs/firehose/lib/src/changelog.dart 💚 100 %
pkgs/firehose/lib/src/delayed_client.dart 💚 23 %
pkgs/firehose/lib/src/github.dart 💚 68 %
pkgs/firehose/lib/src/health/changelog.dart 💚 97 %
pkgs/firehose/lib/src/health/coverage.dart 💔 76 % ⬇️ 1 %
pkgs/firehose/lib/src/health/health.dart 💔 92 % ⬇️ 3 %
pkgs/firehose/lib/src/health/lcov.dart 💚 89 %
pkgs/firehose/lib/src/health/license.dart 💚 100 %
pkgs/firehose/lib/src/pub.dart 💚 89 %
pkgs/firehose/lib/src/repo.dart 💔 91 % ⬇️ 2 %
pkgs/firehose/lib/src/utils.dart 💚 24 %
pkgs/firehose/test_data/base_test_repo/pkgs/package1/bin/package1.dart 💔 Not covered
pkgs/firehose/test_data/base_test_repo/pkgs/package1/lib/package1.dart 💔 Not covered
pkgs/firehose/test_data/base_test_repo/pkgs/package1/test/package1_test.dart 💔 Not covered
pkgs/firehose/test_data/base_test_repo/pkgs/package2/bin/package2.dart 💔 Not covered
pkgs/firehose/test_data/base_test_repo/pkgs/package2/lib/package2.dart 💔 Not covered
pkgs/firehose/test_data/base_test_repo/pkgs/package2/test/package2_test.dart 💔 Not covered
pkgs/firehose/test_data/base_test_repo/pkgs/package3/bin/package3.dart 💔 Not covered
pkgs/firehose/test_data/base_test_repo/pkgs/package3/lib/package3.dart 💔 Not covered
pkgs/firehose/test_data/base_test_repo/pkgs/package3/test/package3_test.dart 💔 Not covered
pkgs/firehose/test_data/base_test_repo/pkgs/package5/lib/package5.dart 💔 Not covered
pkgs/firehose/test_data/base_test_repo/pkgs/package5/lib/src/package5_base.dart 💔 Not covered
pkgs/firehose/test_data/test_repo/pkgs/package1/bin/package1.dart 💔 Not covered
pkgs/firehose/test_data/test_repo/pkgs/package1/lib/package1.dart 💔 Not covered
pkgs/firehose/test_data/test_repo/pkgs/package1/test/package1_test.dart 💔 Not covered
pkgs/firehose/test_data/test_repo/pkgs/package2/bin/package2.dart 💔 Not covered
pkgs/firehose/test_data/test_repo/pkgs/package2/lib/anotherLib.dart 💔 Not covered
pkgs/firehose/test_data/test_repo/pkgs/package2/lib/package2.dart 💔 Not covered
pkgs/firehose/test_data/test_repo/pkgs/package2/test/package2_test.dart 💔 Not covered
pkgs/firehose/test_data/test_repo/pkgs/package3/bin/package3.dart 💔 Not covered
pkgs/firehose/test_data/test_repo/pkgs/package3/lib/package3.dart 💔 Not covered
pkgs/firehose/test_data/test_repo/pkgs/package3/test/package3_test.dart 💔 Not covered
pkgs/firehose/test_data/test_repo/pkgs/package5/lib/package5.dart 💔 Not covered
pkgs/firehose/test_data/test_repo/pkgs/package5/lib/src/package5_base.dart 💔 Not covered

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

@mosuem mosuem requested a review from devoncarew October 24, 2024 16:25
@mosuem mosuem changed the title Test Updates to health.yaml Oct 24, 2024
@mosuem mosuem removed the request for review from devoncarew October 24, 2024 16:26
@mosuem mosuem requested a review from devoncarew October 24, 2024 16:41
.github/workflows/health_base.yaml Outdated Show resolved Hide resolved
@@ -48,17 +48,23 @@ void main(List<String> arguments) async {
..addFlag(
'coverage_web',
help: 'Whether to run web tests for coverage',
)
..addMultiOption(
'flutter_packages',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see we're using a foo_bar naming convention here and for the other options. I believe a foo-bar convention is more common for args, but likely not worth changing here or being inconsistent w/ the other option names.

mosuem and others added 2 commits October 31, 2024 14:34
@mosuem mosuem marked this pull request as ready for review November 11, 2024 09:12
Copy link
Member

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change, as the use-flutter argument is not existing anymore. After landing this, all dart-lang/ repos will have to be updated. As part of that update, we should maybe have the health.yamls depend on a hash instead of the main branch.

We won't break things much, and should be able to get down to just having ~a dozen repos to update; I think either referencing main or a hash would work. We could also create releases, and then reference the more semantic tag (healthcheck-v0.2.0). I don't think that would save us time however - for any change we wanted roll out we'd need to send PRs to all the monorepos.

@mosuem mosuem merged commit 8749a2b into main Dec 6, 2024
14 checks passed
@mosuem mosuem deleted the forceFlutter branch December 6, 2024 12:43
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Dec 9, 2024
Revisions updated by `dart tools/rev_sdk_deps.dart`.

core (https://github.com/dart-lang/core/compare/abcf992..7f9f597):
  7f9f597e  2024-12-03  Devon Carew  update the pubspec version of package:collection (dart-lang/core#730)

ecosystem (https://github.com/dart-lang/ecosystem/compare/248b180..b4b2a43):
  b4b2a43  2024-12-06  Moritz  Unsubmit donotsubmit (dart-lang/ecosystem#324)
  8749a2b  2024-12-06  Moritz  Updates to `health.yaml` (dart-lang/ecosystem#310)
  10fb2c0  2024-12-05  Moritz  Ecosystem testing (dart-lang/ecosystem#320)

test (https://github.com/dart-lang/test/compare/2096773..dc0f8ea):
  dc0f8ea4  2024-12-04  Nate Bosch  Fix hang after multiple precompiled browser tests (dart-lang/test#2422)

tools (https://github.com/dart-lang/tools/compare/1c5b8b9..223daf5):
  223daf53  2024-12-05  Ben Konyi  Update `package:vm_service` constraints to >=12.0.0 <16.0.0 (dart-lang/tools#1205)

vector_math (https://github.com/google/vector_math.dart/compare/433fb6c..bd4b574):
  bd4b574  2024-12-09  Plague Fox  Partial fix for benchmarks (google/vector_math.dart#337)

Change-Id: Ie5ce1e95647ac19af1dcfd1d5ee495659052ddc9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/399701
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:firehose skip-do-not-submit-check type-infra A repository infrastructure change or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants