Change to ArgumentError

dart-lang · Mar 7, 2024 · 542ed12 · 542ed12
1 parent 8bc9c3a
commit 542ed12
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/pkgs/web_socket/lib/src/browser_web_socket.dart b/pkgs/web_socket/lib/src/browser_web_socket.dart
@@ -28,7 +28,8 @@ class BrowserWebSocket implements WebSocket {
   static Future<BrowserWebSocket> connect(Uri url,
       {Iterable<String>? protocols}) async {
     if (!url.isScheme('ws') && !url.isScheme('wss')) {
-      throw WebSocketException("Unsupported URL scheme '${url.scheme}'");
+      throw ArgumentError.value(
+          url, 'url', 'only ws: and wss: schemes are supported');
     }
 
     final webSocket = web.WebSocket(url.toString(),

diff --git a/pkgs/web_socket/lib/src/io_web_socket.dart b/pkgs/web_socket/lib/src/io_web_socket.dart
@@ -25,6 +25,11 @@ class IOWebSocket implements WebSocket {
   /// [RFC-6455 1.9](https://datatracker.ietf.org/doc/html/rfc6455#section-1.9).
   static Future<IOWebSocket> connect(Uri url,
       {Iterable<String>? protocols}) async {
+    if (!url.isScheme('ws') && !url.isScheme('wss')) {
+      throw ArgumentError.value(
+          url, 'url', 'only ws: and wss: schemes are supported');
+    }
+
     final io.WebSocket webSocket;
     try {
       webSocket =

diff --git a/pkgs/web_socket_conformance_tests/lib/src/connect_uri_tests.dart b/pkgs/web_socket_conformance_tests/lib/src/connect_uri_tests.dart
@@ -12,7 +12,7 @@ void testConnectUri(
   group('connect uri', () {
     test('no protocol', () async {
       await expectLater(() => channelFactory(Uri.https('www.example.com', '/')),
-          throwsA(isA<WebSocketException>()));
+          throwsA(isA<ArgumentError>()));
     });
   });
 }