Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cronet_http] Apply relevant rules with the ProGuard #1204

Merged
merged 4 commits into from
May 24, 2024
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkgs/cronet_http/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 1.2.2-wip
AlexV525 marked this conversation as resolved.
Show resolved Hide resolved

* Add relevant rules with the ProGuard to avoid runtime exceptions.

## 1.2.1

* Upgrade `package:jni` to 0.9.2 to fix the build error in the latest versions
Expand Down
3 changes: 3 additions & 0 deletions pkgs/cronet_http/android/consumer-rules.pro
Original file line number Diff line number Diff line change
@@ -1 +1,4 @@
-keep class io.flutter.plugins.cronet_http.** { *; }
-keep class java.net.URL { *; }
-keep class java.util.concurrent.Executors { *; }
-keep class org.chromium.net.** { *; }
1 change: 1 addition & 0 deletions pkgs/cronet_http/example/android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -73,5 +73,6 @@ dependencies {
implementation(platform("org.jetbrains.kotlin:kotlin-bom:1.8.0"))
// ""com.google.android.gms:play-services-cronet" is only present so that
// `jnigen` will work. Applications should not include this line.
// The version should be synced with `pkgs/cronet_http/android/build.gradle`.
implementation "com.google.android.gms:play-services-cronet:18.0.1"
}
2 changes: 1 addition & 1 deletion pkgs/cronet_http/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: cronet_http
version: 1.2.1
version: 1.2.2-wip
AlexV525 marked this conversation as resolved.
Show resolved Hide resolved
description: >-
An Android Flutter plugin that provides access to the Cronet HTTP client.
repository: https://github.com/dart-lang/http/tree/master/pkgs/cronet_http
Expand Down
Loading