Type hierarchy use type #123
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmorgan
force-pushed
the
type-hierarchy-use-type
branch
from
fff98d3 to
3a923d2
Compare
jakemac53
reviewed
Oct 29, 2024
| } | ||
|
|
||
| bool get isMember => wireType == WireType.member; | ||
| Member? get maybeMember => isMember ? asMember : null; |
There was a problem hiding this comment.
nit: maybe ifMember? I don't feel strongly either way though.
We probably also want to avoid looking up wireType twice here.
| final path = MacroScope.current.model.pathOf(node)!; | ||
| final secondLast = path[path.length - 2]; | ||
| switch (secondLast) { | ||
| case 'members': |
There was a problem hiding this comment.
I definitely would want something more robust here, it needs to be something we can auto-generate as well I think.
In general, I don't love the idea of using the path to the node for this this, it feels sketchy and I worry about the backwards compatibility of it if the schema changes.
There was a problem hiding this comment.
Agreed, I'm happy to drop the path idea in favour of putting "static fields" in schemas, that seems much better and can be used for any of the approaches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.