Extend benchmark_generator to more macros #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakemac53
approved these changes
Nov 21, 2024
davidmorgan
force-pushed
the
built-value-benchmark
branch
from
04fb59d to
c94ef79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that the first commit is sent as a separate PR #145.
Fix the
built_valuemacro handling of null fields.This allows generating benchmarks applying
JsonCodable,BuiltValueor both.I tried some initial runs with both, and ... I guess I shouldn't be surprised, running both does not share much work today, e.g. time to first analysis with 64 files is
JsonCodable: 6.4s
BuiltValue: 7.4s
Both: 12.8s
which saves 1s over 6.4s+7.4s=13.8s.
For comparison the "without macros" time to first analysis is
JsonCodable: 2.1s
BuiltValue: 3.9s
Both: 4.2s