Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix converting type annotations #157

Merged
merged 1 commit into from
Dec 16, 2024
Merged

fix converting type annotations #157

merged 1 commit into from
Dec 16, 2024

Conversation

eEQK
Copy link
Contributor

@eEQK eEQK commented Dec 15, 2024

without convertToTypeAnnotation the typeAnnotation.type did not exist and you were not able to convert to any type annotation (e.g. .asNamedTypeAnnotation threw error)

@eEQK eEQK force-pushed the fix-convert-type-annotation branch from 6f65188 to 85fb453 Compare December 15, 2024 14:22
davidmorgan
davidmorgan approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@davidmorgan davidmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

We're not really ready to push on this code right now, but this is a straightforward fix, so I'll merge it--thanks.

The continuous build failures are unrelated, it's due to a CFE version mismatch.

@davidmorgan davidmorgan merged commit 1e13d2f into dart-lang:main Dec 16, 2024
49 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidmorgan davidmorgan davidmorgan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eEQK @davidmorgan