Skip to content

Commit

Permalink
Stop hiding package:objective_c build warnings, and fix exisitng warn…
Browse files Browse the repository at this point in the history
…ings
  • Loading branch information
liamappelbe committed Dec 19, 2024
1 parent 32c136a commit 4f49843
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
2 changes: 1 addition & 1 deletion pkgs/objective_c/src/objective_c.m
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ @interface DOBJCWaiter : NSObject {}
@property(strong) NSCondition* cond;
@property bool done;
-(void)signal;
-(void)wait;
-(void)wait: (double)timeoutSeconds;
@end

@implementation DOBJCWaiter
Expand Down
6 changes: 2 additions & 4 deletions pkgs/objective_c/test/setup.dart
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,6 @@ const objCFlags = [
'-x',
'objective-c',
'-fobjc-arc',
'-framework',
'Foundation'
];
final outputFile = _resolve('test/objective_c.dylib');

Expand All @@ -57,10 +55,10 @@ void _runClang(List<String> flags, String output) {
const exec = 'clang';
print('Running: $exec ${args.join(" ")}');
final proc = Process.runSync(exec, args);
print(proc.stdout);
print(proc.stderr);
if (proc.exitCode != 0) {
exitCode = proc.exitCode;
print(proc.stdout);
print(proc.stderr);
throw Exception('Command failed: $exec ${args.join(" ")}');
}
print('Generated $output');
Expand Down

0 comments on commit 4f49843

Please sign in to comment.