Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[infra] Fix CI #1114

Merged
merged 3 commits into from
May 2, 2024
Merged

[infra] Fix CI #1114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0c27109
[native_assets_cli] Fix example analysis
dcharkes May 1, 2024
e19e6b8
Fix another example
dcharkes May 1, 2024
6cbbda3
Try not installing NDK
dcharkes May 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/native.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ jobs:
- uses: nttld/setup-ndk@6a7e9c5494a25c4842ca1011f710300132eacd94
with:
ndk-version: r26b
if: ${{ matrix.sdk == 'stable' }}
if: ${{ matrix.sdk == 'stable' && matrix.os != 'macos' }}

- run: dart pub get

Expand Down
4 changes: 2 additions & 2 deletions pkgs/native_assets_builder/test_data/dart_app/bin/dart_app.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,15 @@ void main() {
void testNativeAdd() {
final answer = add(5, 6);
if (answer != 5 + 6) {
throw 'Wrong answer';
throw Exception('Wrong answer');
}
print('add(5, 6) = $answer');
}

void testNativeSubtract() {
final answer = subtract(5, 6);
if (answer != 5 - 6) {
throw 'Wrong answer';
throw Exception('Wrong answer');
}
print('subtract(5, 6) = $answer');
}
4 changes: 2 additions & 2 deletions pkgs/native_assets_cli/example/use_dart_api/test/use_dart_api_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,14 @@

import 'dart:ffi';

import 'package:use_dart_api/use_dart_api.dart';
import 'package:test/test.dart';
import 'package:use_dart_api/use_dart_api.dart';

void main() {
InitDartApiDL(NativeApi.initializeApiDLData);

test('use dart_api_dl.h', () {
const int x = 42;
const x = 42;
final persistentHandle = NewPersistentHandle(x);
HandleFromPersistent(persistentHandle);
});
Expand Down
Loading