-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ffigen] Prepare to publish v15.0.0 #1649
Conversation
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. Coverage ✔️
This check for test coverage is informational (issues shown here will not fail the PR). License Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
|
Let me patch in this change and see if I can figure out the reference leak. |
I don't understand the reference leak and cannot reproduce it in a flutter app with identical code. I've tried to use observatory to find the reference in the test but can't get observatory to work consistently in the test environment. |
@@ -3,7 +3,7 @@ | |||
# BSD-style license that can be found in the LICENSE file. | |||
|
|||
name: ffigen | |||
version: 15.0.0-wip | |||
version: 15.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be released simultaneously with package:objective_c
3.0.0? Otherwise version solving will fail for package:ffigen
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep
Adding a ref counting test for package:objective_c's
NSInputStream
, but it looks like there's a memory leak. See #1665