[native_assets_cli] Move targetOS to CodeConfig
#1806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkustermann
approved these changes
Dec 11, 2024
| @@ -188,7 +189,7 @@ class CBuilder extends CTool implements Builder { | |||
| name: assetName!, | |||
| file: libUri, | |||
| linkMode: linkMode, | |||
| os: config.targetOS, | |||
| os: config.codeConfig.targetOS, | |||
There was a problem hiding this comment.
Here we pass os: and architecture: separately. It may? be more idiomatic to pass an Abi object here instead.
There was a problem hiding this comment.
If we go that direction, we should also have config.codeConfig.targetAbi instead of OS and architecture. But that might make config.codeConfig.android.ndkVersion less obvious again. Anyway, let's discuss that in a separate issue.
|
Thanks @mkustermann! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next refactoring in:
BuildConfig.targetOStoBuildConfig.codeConfig.targetOS, remove it entirely or extend to cover web #1738We move
config.targetOStoconfig.codeConfig.targetOS. Other asset types might not get access on the target OS.This will require a manual roll into dartdev and flutter tools due to the targetOS now having to be passed in via
setupCodeConfiginstead of the base config.The native assets builder will still emit the same JSON if code assets are supported. Since both Dart and Flutter support code assets currently, this will not break anything. Once data assets for web in Flutter are added, all existing build hooks that assume code assets are always supported will break.